Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp160775pxk; Wed, 9 Sep 2020 01:48:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUDxtaM9v63/wpEWxfWwW02RRYXXDSR6RmHGiajKxOLALlHqvPtpF66ZtcKkCj1u8Oy5ob X-Received: by 2002:a17:906:edc4:: with SMTP id sb4mr2571411ejb.144.1599641293033; Wed, 09 Sep 2020 01:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599641293; cv=none; d=google.com; s=arc-20160816; b=H7oGG8WOOiqzZsiRMWeSRvTIJXbXxjSmrsTuXhzebGzkl1IYQ7CnZXmWdeLdh6N4RN h15fO5nin/YrNbMiCwIXKP9UFTfTbu6Izc6HSt2fX6VkbK89DuLeF54rfSYARAeiTvux HbCoFtuU5JK+YG221vKBJv3tXdeH83qhd6v+w2N3VTFaxGxG1BSiFMySH3BVhhw8ATWb j7iEM/J2R1fsX7c62QhYel/FNr2Sp7lfBMJwKGLgbyO5E02s28svq+Ow/hnOApRwlP7o Pa4DfrKiFjFkrny8wqIm5iB/x08z5jYxxv5tVV9E089pq6eHOqRjL0h1gbZxkF4zAW6L ho4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wR26/N/P8vN3iBRh8ILP3mgxHEn2eSpcM01wHdHmu8M=; b=gtTdg5WeVCNg2iUsGses9Wu5HmyYiYR/Z4C1XqtyX/ALWENo4HkhIWHQnO/3FRnqqJ XXwXuwDrYGTqfK9ZFUNLb/fSx3RLdu5YxHHiadxk52E/QtSRexJDyDEyUZaBj135jZZz Hc/A0tRg2055GtKgE5Ku8C0rddbLCUwyn4lDSVzY8iA9nnHdoVNoBy7kApRTSoT8fzBe GRfXm5EZZvKTMqLt+FqLKCu1jCq7S3lKLNpNMzVNUDPeNBRY+bndgaLp1a5Pc3VGHwEz ZfCLvWwLkKdloz5ySP56JG6aj02xFTvOQgBv+N7z3OuTBbWHYVQyf5CtUgVva6guZJlV TwlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si1052250ejg.126.2020.09.09.01.47.50; Wed, 09 Sep 2020 01:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729507AbgIIIqd (ORCPT + 99 others); Wed, 9 Sep 2020 04:46:33 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:40662 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729986AbgIIIqa (ORCPT ); Wed, 9 Sep 2020 04:46:30 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 77862B920E8747D5D302; Wed, 9 Sep 2020 16:46:28 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 9 Sep 2020 16:46:21 +0800 From: Jing Xiangfeng To: , , CC: , , Subject: [PATCH] scsi: esas2r: prevent a potential NULL dereference in esas2r_probe() Date: Wed, 9 Sep 2020 16:46:53 +0800 Message-ID: <20200909084653.79341-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org esas2r_probe() calls scsi_host_put() in an error path. However, esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead. Signed-off-by: Jing Xiangfeng --- drivers/scsi/esas2r/esas2r_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/esas2r/esas2r_main.c b/drivers/scsi/esas2r/esas2r_main.c index 7b49e2e9fcde..7d3fa9dac4ce 100644 --- a/drivers/scsi/esas2r/esas2r_main.c +++ b/drivers/scsi/esas2r/esas2r_main.c @@ -456,7 +456,7 @@ static int esas2r_probe(struct pci_dev *pcid, scsi_host_put(host); - esas2r_log_dev(ESAS2R_LOG_INFO, &(host->shost_gendev), + esas2r_log_dev(ESAS2R_LOG_INFO, NULL, "pci_set_drvdata(%p, NULL) called", pcid); -- 2.17.1