Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp183299pxk; Wed, 9 Sep 2020 02:36:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9DDExwyOn2Ft1D+tOFbFKSXs7YFC9M8WJuOnDcGhTaXb+HYx6lSUp1ZqjMLqhTuUh9wj1 X-Received: by 2002:a17:906:fb8c:: with SMTP id lr12mr2905656ejb.9.1599644167410; Wed, 09 Sep 2020 02:36:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599644167; cv=none; d=google.com; s=arc-20160816; b=ml7tl1vPXTkcqbW/CAGQFerLx7fxB2hgAyT5edA7tf3u0/vl+DDoh/Seh81HY5hu3P HK2LGsk6++UXpOqjC/h4PQOTrSqMiKTgzOvTd11sGFWAQdUx7mIlDl4SLTgXI3z8BlEz u5ZGQJlwTyVzck/bFGxx89qYQFRI+BSyS8s85VmsIst0atxyGJrPEhK3llU66U3gg3zO PKW2z5lFs1x9SnoroH6SsNzEeAEMvZmhF5s/TFt3Ketnt76sgj5Jtl1IGIDcI6C0hg+z EfLUe0rBkRiGv1SthqT9hwNAKmuQ5Prl1TWMP8mpEYM0Lw2dCzA6WrSQODxFR+7KVKuT o2Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=pUQTv0UwcEAnnVIsbVlIPVNHF0/vxHu+weScX6eEMtQ=; b=FMyCM207Fqsjgz9LyS7u9sqOj847GvUp+vsrnONiELrMZr0NzdgYn2bbz/KkSymKLb YISDN/LpfuuR3zjjcXhjU9PNMso4WTYmf/TvAdeXSjtsT0gEpDLAaAfCqVRwb/5Lh/jK WqXdu1NP7EaFmCcNI8U6AVnHu+QSE6Ar9mXTEjYn0aciPcO+36Er3hsSSpcJLrZ2qysj RAZ7UTemPjSww6qUi5mWhRnI8AAAqdaNFKwlg9RJUJQJ7jx/xcTMUby+ofNHrv4TXGQw NvPN2wBSEmIDsawlDJCB39dU5UlXim0NgAdyvI8Ru/hzc9vXD6hdIi9doAshNY0jzpge trVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=tFSCEFZP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j26si1075528edf.88.2020.09.09.02.35.44; Wed, 09 Sep 2020 02:36:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=tFSCEFZP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729738AbgIIJej (ORCPT + 99 others); Wed, 9 Sep 2020 05:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728663AbgIIJeb (ORCPT ); Wed, 9 Sep 2020 05:34:31 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43370C061573 for ; Wed, 9 Sep 2020 02:34:31 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id i1so1974179edv.2 for ; Wed, 09 Sep 2020 02:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pUQTv0UwcEAnnVIsbVlIPVNHF0/vxHu+weScX6eEMtQ=; b=tFSCEFZP3KHzbou/mPsbn1mzHp2NXTkmke31/SYSdOb0XcDRuVh3fAvvEu5gUijjBP 0opI7TeH1UjoTSGwrtdgLGbddFfGlH+C7IqU+sgS8V+1FISSEZba0FS6XeYY/l+MbWU+ 4BI/T5Vx+O2KpAGzfL4Sc78I1xtdXQKpl9YWNm9myelO8L/P5bXmvMiscO7/8kv4lNFo cgpBuEMc8zdzsY8BbbO+IywssO1sCUeDIOedqw+IYxDuxaX4Vpd4lgdpE+cPoIQd2wdT eKVeyurIT1D+h74BvRJgVNonw7nPcNr15Y7abxXNHWLGtD3CPNNoLGKMeyqaVAa8a1hV V+Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pUQTv0UwcEAnnVIsbVlIPVNHF0/vxHu+weScX6eEMtQ=; b=FV5eFrFV75ZsY4ufLozbroLkx51uhFtOVUJB6oNnZBccw7RJA0ZIwWjaJWVjD4j60J dxFFiP4rbcZO8DEEOTbCS5m58GjIov/G+2iZJ7KP31TFUlQZ5naCOEhqwUQOQ8xjluGh gwpkTBRGWoUglwBb+07mFNcQyLLCTPqysxQyCtqBGB/84gzxxsZIE/okMM91BNXadA6K gqSfyYHelLvhsjD35GaxAAtz7j53BRMwgvRg11nRuMycRGggTfdUYR48RQmb2o60oT+n qRTMwEzSx6JtyD7CSRUElfd7OMQQ3xrMmqwEgNh23E2qp/h8zil9Kwln1y+CHqVTWeYK IWBA== X-Gm-Message-State: AOAM530xnB7B/00AzObMmmKrs7KvS6plpwIgQbQyx1dA8wOaFmLXCXRJ fqh+1q5QElgp97CEj5k0+P4Lpji71ZaVLL+/tYsKbg== X-Received: by 2002:a05:6402:615:: with SMTP id n21mr3029737edv.59.1599644068361; Wed, 09 Sep 2020 02:34:28 -0700 (PDT) MIME-Version: 1.0 References: <1599118222-18990-1-git-send-email-dillon.minfei@gmail.com> <1599118222-18990-2-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1599118222-18990-2-git-send-email-dillon.minfei@gmail.com> From: Bartosz Golaszewski Date: Wed, 9 Sep 2020 11:34:17 +0200 Message-ID: Subject: Re: [PATCH: V2 1/2] gpio: tc35894: fix up tc35894 interrupt configuration To: dillon.minfei@gmail.com Cc: Linus Walleij , Lee Jones , linux-gpio , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 3, 2020 at 9:30 AM wrote: > > From: dillon min > > The offset of regmap is incorrect, j * 8 is move to the > wrong register. > > for example: > > asume i = 0, j = 1. we want to set KPY5 as interrupt > falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd > but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4, > this is TC3589x_GPIOIE2 not TC3589x_GPIOIBE1. > > Fixes: d88b25be3584 ("gpio: Add TC35892 GPIO driver") > Signed-off-by: dillon min > --- > Queued for fixes. Thanks! Bartosz