Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <729431b40a2c0744f8f5496f7f90c612a318bd8c.camel@pengutronix.de>
Subject: Re: [PATCH] sched/deadline: Fix stale throttling on de-/boosted
 tasks
From:   Lucas Stach <l.stach@pengutronix.de>
To:     peterz@infradead.org, Juri Lelli <juri.lelli@redhat.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        patchwork-lst@pengutronix.de
Date:   Wed, 09 Sep 2020 14:59:01 +0200
In-Reply-To: <20200902094339.GZ1362448@hirez.programming.kicks-ass.net>
References: <20200831110719.2126930-1-l.stach@pengutronix.de>
         <20200902060024.GK16601@localhost.localdomain>
         <20200902094339.GZ1362448@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mi, 2020-09-02 at 11:43 +0200, peterz@infradead.org wrote:
> On Wed, Sep 02, 2020 at 08:00:24AM +0200, Juri Lelli wrote:
> > On 31/08/20 13:07, Lucas Stach wrote:
> > > When a boosted task gets throttled, what normally happens is that it's
> > > immediately enqueued again with ENQUEUE_REPLENISH, which replenishes the
> > > runtime and clears the dl_throttled flag. There is a special case however:
> > > if the throttling happened on sched-out and the task has been deboosted in
> > > the meantime, the replenish is skipped as the task will return to its
> > > normal scheduling class. This leaves the task with the dl_throttled flag
> > > set.
> > > 
> > > Now if the task gets boosted up to the deadline scheduling class again
> > > while it is sleeping, it's still in the throttled state. The normal wakeup
> > > however will enqueue the task with ENQUEUE_REPLENISH not set, so we don't
> > > actually place it on the rq. Thus we end up with a task that is runnable,
> > > but not actually on the rq and neither a immediate replenishment happens,
> > > nor is the replenishment timer set up, so the task is stuck in
> > > forever-throttled limbo.
> > > 
> > > Clear the dl_throttled flag before dropping back to the normal scheduling
> > > class to fix this issue.
> > > 
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > Acked-by: Juri Lelli <juri.lelli@redhat.com>
> 
> Thanks!

Does this mean the patch will get picked up as-is, or are there any
changes required?

Regards,
Lucas