Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200908145900.4423-1-krzk@kernel.org>
In-Reply-To: <20200908145900.4423-1-krzk@kernel.org>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Wed, 9 Sep 2020 08:22:49 -0700
Message-ID: <CAJ+vNU3COwMZuPMLO8XYtKcVsGLawhpzuBC3XRMdkU01ePJi+Q@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Robert Jones <rjones@gateworks.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        Device Tree Mailing List <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        linux-power@fi.rohmeurope.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Sep 8, 2020 at 7:59 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted some
> logical behavior behind the name "ACTIVE_xxx", this is:
>   ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/mfd/act8945a.txt          | 2 +-
>  Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml    | 3 ++-
>  Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 2 +-
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> index e6f168db6c72..5ca75d888b4a 100644
> --- a/Documentation/devicetree/bindings/mfd/act8945a.txt
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -71,7 +71,7 @@ Example:
>                         pinctrl-names = "default";
>                         pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
>                         interrupt-parent = <&pioA>;
> -                       interrupts = <45 GPIO_ACTIVE_LOW>;
> +                       interrupts = <45 IRQ_TYPE_LEVEL_LOW>;
>
>                         active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
>                         active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;
> diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> index 9b6eb50606e8..e541eb0d02ed 100644
> --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> @@ -147,6 +147,7 @@ required:
>  examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
>      i2c {
>          #address-cells = <1>;
>          #size-cells = <0>;
> @@ -155,7 +156,7 @@ examples:
>              compatible = "gw,gsc";
>              reg = <0x20>;
>              interrupt-parent = <&gpio1>;
> -            interrupts = <4 GPIO_ACTIVE_LOW>;
> +            interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
>              interrupt-controller;
>              #interrupt-cells = <1>;
>              #address-cells = <1>;

For gateworks-gsc.yaml:
Acked-By: Tim Harvey <tharvey@gateworks.com>

Thanks for finding this!

Tim