Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp426035pxk; Wed, 9 Sep 2020 08:53:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpKAN7GyPEgLfCd3wGQrVyNpdijLwLBU43qJ8hB9VfuorjT6otr84JscXvV5OwjBZMh5pa X-Received: by 2002:a17:906:249b:: with SMTP id e27mr3326651ejb.105.1599666814557; Wed, 09 Sep 2020 08:53:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599666814; cv=none; d=google.com; s=arc-20160816; b=tBVgEZ2Pr3qVk+CmEfeIEtm1i5+gz+2TRSYCuLEo/PlwJzmKiaYjz/QlrT8EWBQ668 xQLzoCrDE8HHp2a4xjeFocIWapumWGa3zqng2kES8sh306+ZEBNX8TKhjHVsJIEiXRx2 2D99iLv55xZ4pIKgsWfgPUetbosSuZuLxRKSoROA+0zQfowGkK6u0Av8j37PCMaW1KQw TMyfpvViRFeDbxJIpqxLFwNXmygBdEPM5irIRLEdQ1iOU6cwM/R3bzDjmY71mycKkLrz 66MyhQN7hgPk2en0LjLIuXlcjO/sZhnPjK/iYc4KTBzEKTBUjsSfNy84mqseN5hS2uxZ 6FIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=Ky8u5V/th/v/tf+Q7eLpMxHnRviGkQPtzvV05l6+ZFk=; b=Eo6JJsXwJ0YCbQrWV0sxHrv6gYa1xODrr/jHC/LSDnlHfXNBnuvjk+X16kAQ2367CD BBUTDM41qxIIzCKNCDaTpaJeqAuiT1IZ9YpzKLb23fFw71owIuAsPvWBfhEud/KHrTxN lqE+TOzLivWaDzEolKN7KeL+vg9OIKo+iPLTMkm6aTWUIFGKkBYVq407ijcjIeG63+7o nIrKXa/sB+sckBAsi/+9NOfU6Cd+C9hNM6mwv/aAmlGh00pPDZad2ZzbGdPmF25jsQSs ywUPCY2ZxQPA8gOIfQ5LaVuLo1dJuCg7ZMhyvdSGK2TJZzZVNMfwOtNtoNicTT8Z+P+g 3IRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E0N7nnj7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q4si1814390ejd.380.2020.09.09.08.53.11; Wed, 09 Sep 2020 08:53:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E0N7nnj7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730497AbgIIPtY (ORCPT + 99 others); Wed, 9 Sep 2020 11:49:24 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:57472 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730509AbgIIPqn (ORCPT ); Wed, 9 Sep 2020 11:46:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599666400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ky8u5V/th/v/tf+Q7eLpMxHnRviGkQPtzvV05l6+ZFk=; b=E0N7nnj7txGr6G6FHmuoX43wNcZEZBhZPso6iEt95jPVbiP5AkTjaETb0F4ITZ3NiWCipO CGokSV+OyS3n1b5tl29TY0UfrzonEeobAgvLef90RjkDWakwW5/+YJMShxum8NF4yao6nT zKnLt/0KvqTTHB5mTXWnZCvc/0JSySo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-wf7vO7Y8PbmhvrThUYqrcw-1; Wed, 09 Sep 2020 09:28:03 -0400 X-MC-Unique: wf7vO7Y8PbmhvrThUYqrcw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 911788015A4; Wed, 9 Sep 2020 13:28:01 +0000 (UTC) Received: from [10.36.113.90] (ovpn-113-90.ams2.redhat.com [10.36.113.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14FAB19C4F; Wed, 9 Sep 2020 13:27:57 +0000 (UTC) Subject: Re: [RFC PATCH 00/16] 1GB THP support on x86_64 To: Jason Gunthorpe , Matthew Wilcox Cc: Zi Yan , Roman Gushchin , "Kirill A. Shutemov" , linux-mm@kvack.org, Rik van Riel , "Kirill A . Shutemov" , Shakeel Butt , Yang Shi , David Nellans , linux-kernel@vger.kernel.org References: <20200902180628.4052244-1-zi.yan@sent.com> <20200903142300.bjq2um5y5nwocvar@box> <20200903163020.GG60440@carbon.dhcp.thefacebook.com> <8e677ead-206d-08dd-d73e-569bd3803e3b@redhat.com> <7E20392E-5ED7-4C22-9555-F3BAABF3CBE9@nvidia.com> <20200908142758.GF27537@casper.infradead.org> <20200909121117.GD87483@ziepe.ca> <20200909123244.GD6583@casper.infradead.org> <20200909131449.GF87483@ziepe.ca> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63W5Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAjwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat GmbH Message-ID: <53b360d4-8d16-892b-0f7f-5c4cd95208d8@redhat.com> Date: Wed, 9 Sep 2020 15:27:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200909131449.GF87483@ziepe.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.09.20 15:14, Jason Gunthorpe wrote: > On Wed, Sep 09, 2020 at 01:32:44PM +0100, Matthew Wilcox wrote: > >> But here's the thing ... we already allow >> mmap(MAP_POPULATE | MAP_HUGETLB | MAP_HUGE_1GB) >> >> So if we're not doing THP, what's the point of this thread? > > I wondered that too.. > >> An madvise flag is a different beast; that's just letting the kernel >> know what the app thinks its behaviour will be. The kernel can pay > > But madvise is too late, the VMA already has an address, if it is not > 1G aligned it cannot be 1G THP already. That's why user space (like QEMU) is THP-aware and selects an address that is aligned to the expected THP granularity (e.g., 2MB on x86_64). -- Thanks, David / dhildenb