Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp440352pxk; Wed, 9 Sep 2020 09:14:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytAKAQhxUFWQFg9OFXtMVXOHkkeUgCHxuExI5g9KupmoRBZ2mmw6bZ9tL9zuJZMQ4C9jym X-Received: by 2002:aa7:d648:: with SMTP id v8mr3442250edr.159.1599668042036; Wed, 09 Sep 2020 09:14:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599668042; cv=none; d=google.com; s=arc-20160816; b=UoVVNSK+DyX8XJM8DOjiAVNWPVBL+P8qscdaqhSIcwEQmslRObdSeT1aYhf9ahimXC gm/0Fyek89npxUTk37/QeYrwxyaYou+dXimlFB3yWCwbU+RsitnnfwInlAI+elenjNET mbbt92NH4dCT4ILGm7nC+02t+9BCq/VORfj3M7QoGGGiO35/zAT2iIVmbLbAuGEr14Bk 1Kg8uxyVtE3Sb+QWTs/kuj7h2wKM+Y4ymiohejKTfA4wp2rC4wEjqQXj2OgwhzvOItqR bG8DGmYnjvYOqcyK/dwwxEyQbghPC3k2mqF8GBF4wVV7lmGolqn+S9sXthXtajZoSDQE RpiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XOUyPTsa2Cy1aBInD+QuWOlrkZOb1oPn3ygyN5HSAlw=; b=gT1NEi/6ron3XLtCD6E9bXjNvBZeyrDdhdN9t9JbCxeHPYPec3qxxOA2wMb6DNfZ6V lGfciwLZNIVgQnSLzrDH6r7uZ/06P5QIBu07rFfaNVpObjFUt7Rh59CaVk56E48B/n4l 7hRMgeIwF72zOqIx06K6iHVoysftqudltJ/5oRzPLokM0u6IuzsVByOG1r+gdScthRW/ DRFikvd7WS0qdtk4rUXlqkHo2RweiWM4Wq7CcPwN9g3TtoGndqQQXMdj3W9XZD6MfcGu Y7jdYPWuPItyVw3OIg39w/CMaFgESDi0SQKD3AlnOsl2/hjyjDNZ4ZBFiWayuN9UoFIb YVUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=LoZsiyRN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m27si1747711eja.40.2020.09.09.09.13.39; Wed, 09 Sep 2020 09:14:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=LoZsiyRN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730807AbgIIQMw (ORCPT + 99 others); Wed, 9 Sep 2020 12:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730821AbgIIQJZ (ORCPT ); Wed, 9 Sep 2020 12:09:25 -0400 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D900C061756 for ; Wed, 9 Sep 2020 09:09:20 -0700 (PDT) Received: by mail-qv1-xf44.google.com with SMTP id j10so1766810qvk.11 for ; Wed, 09 Sep 2020 09:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XOUyPTsa2Cy1aBInD+QuWOlrkZOb1oPn3ygyN5HSAlw=; b=LoZsiyRN6z3nQTE+reJEuHSLJx/sEAeC0/lg9Ji/pYlB7dC9jGShyT3icZv0Jh+YaM EYDrMJiztU1bZr5xo1De0LQt8sutI/Gr9qQ7/n2Dj9y6PqFSdYF6U94Rg9WYCPglKd1d 0XX9IN2kGMxwHWlJICG360S5k88hyLU+4KSmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XOUyPTsa2Cy1aBInD+QuWOlrkZOb1oPn3ygyN5HSAlw=; b=idEkoV9rgv4K8y6s4oSDlTTJzxTqCO2/EVf0iq5MHeBRhyEyhU//HnWoWZLafQMmm1 kqjaQKsOrafFrxQ+HOSHmRxbmCXAOm6EkKX9w6rQF1gDBKWtqNA/rcl8be1L99dSOUVq 4qIgaRm4l51tK3Ctg8bc+6n6guIopAKRMpJS1mOyGg5EQsLvc1Yo/OiMfshWRSCG80S1 OqYPjs0OfmWOm1GjKbIRxCbItT6yz24gJ/b0ZfXZu2G51QuGr01N2JOCkaB+qGz/I3bw t4RIOJ2WQUcUl0uHoPzbdMiXmJz3y787Mg8tRmgQ/i06nFaBvqGKbtnAJgnpAQ+OmAOP 5uvQ== X-Gm-Message-State: AOAM533/FjxBR7ALT+07S6VLxmQiCpeFOOCgSs9WJ8kasRG8CRLTI884 g+pq9oSv0v5noM6FCuz9aQd5hA== X-Received: by 2002:a0c:b35d:: with SMTP id a29mr4590496qvf.19.1599667759190; Wed, 09 Sep 2020 09:09:19 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:16fd]) by smtp.gmail.com with ESMTPSA id q3sm2817689qkq.132.2020.09.09.09.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 09:09:18 -0700 (PDT) Date: Wed, 9 Sep 2020 17:09:17 +0100 From: Chris Down To: zangchunxin@bytedance.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH v2] mm/vmscan: fix infinite loop in drop_slab_node Message-ID: <20200909160917.GA1569471@chrisdown.name> References: <20200909152047.27905-1-zangchunxin@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200909152047.27905-1-zangchunxin@bytedance.com> User-Agent: Mutt/1.14.6 (2020-07-11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks! This looks reasonable to me, and avoids hard-to-reason-about changes in the existing semantics. zangchunxin@bytedance.com writes: >Signed-off-by: Chunxin Zang >Signed-off-by: Muchun Song Acked-by: Chris Down