Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Sep 2020 13:01:48 +0100
From:   Mark Brown <broonie@kernel.org>
To:     kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
Cc:     Ashish Kumar <ashish.kumar@nxp.com>,
        Yogesh Gaur <yogeshgaur.83@gmail.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Varun Sethi <V.Sethi@nxp.com>,
        Arokia Samy <arokia.samy@nxp.com>
Subject: Re: [PATCH v1] spi: spi-nxp-fspi: Add ACPI support
Message-ID: <20200909120148.GC4926@sirena.org.uk>
References: <20200908060227.299-1-kuldip.dwivedi@puresoftware.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="69pVuxX8awAiJ7fD"
Content-Disposition: inline
In-Reply-To: <20200908060227.299-1-kuldip.dwivedi@puresoftware.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--69pVuxX8awAiJ7fD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 08, 2020 at 11:32:27AM +0530, kuldip dwivedi wrote:

This appears to be v2 not v1?

> Currently NXP fspi  driver has support of DT only. Adding ACPI
> support to the driver so that it can be used by UEFI firmware
> booting in ACPI mode. This driver will be probed if any firmware
> will expose HID "NXP0009" in DSDT table.

As I said on your previous version:

| Does NXP know about this ID assignment from their namespace?  ACPI IDs
| should be namespaced by whoever's assigning the ID to avoid collisions.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

> @@ -900,6 +910,8 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f)
>  		return ret;
> =20
>  	/* Reset the module */
> +	fspi_writel(f, FSPI_MCR0_SWRST, (base + FSPI_MCR0));
> +
>  	/* w1c register, wait unit clear */
>  	ret =3D fspi_readl_poll_tout(f, f->iobase + FSPI_MCR0,
>  				   FSPI_MCR0_SWRST, 0, POLL_TOUT, false);

Why are you adding this reset?  How is it connected to adding ACPI
support - it looks like it should be a separate patch.

--69pVuxX8awAiJ7fD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9YxCwACgkQJNaLcl1U
h9Dw+Qf/Q3uvLOUD0+1rXIWEQAQHg8wHohO05a6mn6uFYSxUUPgXEy8Z6uSVAhwV
4f7yQVvZohw3A88mE0kNp4/9FJ5Lr0P7s6iFSWmkVKC8oYRAjuy04BYARUeLr/GS
LFoMyxc4OzGUUpqRXNiw6+i7aYZjjQlJ4/OlJwxQGhfW8/vfy+R0fFQE7rpekkvb
mwLVKCbPDhdryUi+ehCqkJ24Yb+DaQFUutr205wGKxbMm0Yv8QWOeuRoUnaysr5e
FbaW0iGGSejcmKezQHqqF99YfY5yPJeFCAUP/n0diqJBcypJHmZBJjV4PgSBAkAA
92ipwXC0WYVajy+isIB3W7zfzmfwXw==
=t/eJ
-----END PGP SIGNATURE-----

--69pVuxX8awAiJ7fD--