Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
CC:     <linux-mm@kvack.org>, Roman Gushchin <guro@fb.com>,
        Rik van Riel <riel@surriel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Shakeel Butt <shakeelb@google.com>,
        Yang Shi <yang.shi@linux.alibaba.com>,
        David Nellans <dnellans@nvidia.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 01/16] mm: add pagechain container for storing
 multiple pages.
Date:   Wed, 9 Sep 2020 10:15:05 -0400
Message-ID: <1970690D-DA0B-4C46-BE0C-66F33D881653@nvidia.com>
In-Reply-To: <20200909134622.xkuzx5nf4xq2vudh@box>
References: <20200902180628.4052244-1-zi.yan@sent.com>
 <20200902180628.4052244-2-zi.yan@sent.com>
 <20200907122228.4zlyfysdul3s62me@box>
 <50FA95D1-9222-48C0-9223-C1267E8C7A4A@nvidia.com>
 <20200909134622.xkuzx5nf4xq2vudh@box>
MIME-Version: 1.0
Content-Type: multipart/signed;
        boundary="=_MailMate_D0E4833B-CB0F-4F80-8EC1-E6EF8EC8C2B3_=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=_MailMate_D0E4833B-CB0F-4F80-8EC1-E6EF8EC8C2B3_=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 9 Sep 2020, at 9:46, Kirill A. Shutemov wrote:

> On Mon, Sep 07, 2020 at 11:11:05AM -0400, Zi Yan wrote:
>> On 7 Sep 2020, at 8:22, Kirill A. Shutemov wrote:
>>
>>> On Wed, Sep 02, 2020 at 02:06:13PM -0400, Zi Yan wrote:
>>>> From: Zi Yan <ziy@nvidia.com>
>>>>
>>>> When depositing page table pages for 1GB THPs, we need 512 PTE pages=
 +
>>>> 1 PMD page. Instead of counting and depositing 513 pages, we can use=
 the
>>>> PMD page as a leader page and chain the rest 512 PTE pages with ->lr=
u.
>>>> This, however, prevents us depositing PMD pages with ->lru, which is=

>>>> currently used by depositing PTE pages for 2MB THPs. So add a new
>>>> pagechain container for PMD pages.
>>>>
>>>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>>>
>>> Just deposit it to a linked list in the mm_struct as we do for PMD if=

>>> split ptl disabled.
>>>
>>
>> Thank you for checking the patches. Since we don=E2=80=99t have PUD sp=
lit lock
>> yet, I store the PMD page table pages in a newly added linked list hea=
d
>> in mm_struct like you suggested above.
>>
>> I was too vague about my pagechain design for depositing page table pa=
ges
>> for PUD THPs. Sorry about the confusion. Let me clarify why
>> I am doing this pagechain here too. I am sure there would be
>> some other designs and I am happy to change my code.
>>
>> In my design, I did not store all page table pages in a single list.
>> I first deposit 512 PTE pages in one PMD page table page=E2=80=99s pmd=
_huge_pte
>> using pgtable_trans_huge_depsit(), then deposit the PMD page to
>> a newly added linked list in mm_struct. Since pmd_huge_pte shares spac=
e
>> with half of lru in struct page, we cannot use lru to link all PMD
>> pages together. As a result, I added pagechain. Also in this way,
>> we can avoid these things:
>>
>> 1. when we withdraw the PMD page during PUD THP split, we don=E2=80=99=
t need
>> to withdraw 513 page, set up one PMD page, then, deposit 512 PTE pages=

>> in that PMD page.
>>
>> 2. we don=E2=80=99t mix PMD page table pages and PTE page table pages =
in a single
>> list, since they are initialized in different ways. Otherwise, we need=

>> to maintain a subtle rule in the single page table page list that in e=
very
>> 513 pages, first one is PMD page table page and the rest are PTE page
>> table pages.
>>
>> As I am typing, I also realize that my current design does not work
>> when PMD split lock is disabled, so I will fix it. I would store PMD p=
ages
>> and PTE pages in two separate lists in mm_struct.
>>
>>
>> Any comments?
>
> Okay, fair enough.
>
> Although, I think you can get away without a new data structure. We don=
't
> need double-linked list to deposit page tables. You can rework PTE tabl=
es
> deposit code to have single-linked list and use one pointer of ->lru (w=
ith
> proper name) and make PMD tables deposit to use the other one. This way=

> you can avoid conflict for ->lru.
>
> Does it make sense?

Yes. Thanks. Will do this in the next version. I think the single linked =
list
from llist.h can be used.

=E2=80=94
Best Regards,
Yan Zi

--=_MailMate_D0E4833B-CB0F-4F80-8EC1-E6EF8EC8C2B3_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJCBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl9Y42kPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqK2g8P9RpqkmfY2NIK9W9h7ldxxXgvwvVbCq2xVMI9
Xj+clVhDb7PbGdN7RP7sgtkNy9woJWAKcAWo+wzILT7KmfN0oFj0ZNTgnyil/MH4
wmKRrFY6bY911Kwjx62Z+xY2E0rXg0MX1Ang7ols8X2uhO1qA2TRwgjw3fwyEzyK
237whK8BW40W0nDUi6NPyqhWRZtvEygrEXqiNV7FxZsKqB0F14HAfHGzzSu2B8pB
E6z0d9X2G6OSn+/Y5UgHmUiXDTuGviTCKPOi4LaA1IYQBSUiUBo8SoxBEjMUdGEC
KKtUmo32tWbi+WFMoG+3u/eO32k6cyYrmpnEu+Bv9dHaqZL1IHlqQsimbV/ik1Td
gQKoNhp3UtGwo1i5BW3MvnF1HMxUlgWQAHLcwl/9DzbKMHCfA67SHxVfI9fsa45b
uxSqfB525/bwT8VePK4qbBjgfkIMeAbt1wrklr3uSPrAlY1AqhbStpzthb2oWaGI
lLzdXGlbKWJHZVrq11mIu5BIc2a3s3YRB8/Rz6s/gJF6OXbidCuTZop9iuIG8ZGS
Qo19XYCIY1wg4NtL6ZRGPQnPIYoOu32A4XUCg90TmqYb2kGqhG+YNAHMJvr87zDG
Dw4e1KeGOK3+05GMnGb5jn5MM9pJuw/8htWmaUwL4GaiPUxDEs+wZ95plYa1PIk+
m8GltQI=
=jndG
-----END PGP SIGNATURE-----

--=_MailMate_D0E4833B-CB0F-4F80-8EC1-E6EF8EC8C2B3_=--