Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next v2 2/9] net: ethernet: ti: ale: add static
 configuration
To:     David Miller <davem@davemloft.net>
CC:     <netdev@vger.kernel.org>, <kuba@kernel.org>, <vigneshr@ti.com>,
        <m-karicheri2@ti.com>, <nsekhar@ti.com>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
References: <20200907143143.13735-1-grygorii.strashko@ti.com>
 <20200907143143.13735-3-grygorii.strashko@ti.com>
 <20200908.192845.1191873689940729972.davem@davemloft.net>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <61332531-0166-c5af-0475-1c338d2ea043@ti.com>
Date:   Wed, 9 Sep 2020 19:51:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200908.192845.1191873689940729972.davem@davemloft.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 09/09/2020 05:28, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> Date: Mon, 7 Sep 2020 17:31:36 +0300
> 
>> +	ale_dev_id = cpsw_ale_match_id(cpsw_ale_id_match, params->dev_id);
>> +	if (ale_dev_id) {
>> +		params->ale_entries = ale_dev_id->tbl_entries;
>> +		params->major_ver_mask = ale_dev_id->major_ver_mask;
> ...
>> -	if (!ale->params.major_ver_mask)
>> -		ale->params.major_ver_mask = 0xff;
> 
> This is exactly the kind of change that causes regressions.
> 
> The default for the mask if no dev_id is found is now zero, whereas
> before the default mask would be 0xff.
> 
> Please don't make changes like this, they are very risky.
> 
> In every step of these changes, existing behavior should be maintained
> as precisely as possible.  Be as conservative as possible.
> 

Sorry and thank you for catching it.
This part belongs to Patch 6. I'll fix it.

-- 
Best regards,
grygorii