Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp483230pxk; Wed, 9 Sep 2020 10:18:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyN4oe5gkBhUegG462OONSJsms6TU2s6NcZ8w4L1byiHT3sMI5qmrw19JG9z+JYbReyTGpm X-Received: by 2002:a17:906:30c5:: with SMTP id b5mr4795313ejb.98.1599671895893; Wed, 09 Sep 2020 10:18:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599671895; cv=none; d=google.com; s=arc-20160816; b=dLDP7ccylZLoXi7OIoiesNoRlr3f5KtTVRM7UkNq01WlliZ79+/bvGrsSTW4oFrUaS kRKJO+nkwiPIsFAWfHOYSqThHEquFZV/xzYQKiH65usXofxozjmR1c+y4Zps4Q8POcT0 xB0ou4I0QlOsfpvddcMbK3WFsjeaiV2fKXGzIqPV+mdh6yW6mOVkU9XykzvzmoaY5eyo g3BG8wfI/dvrRbsUJZjC0nWObwbFLe5yGjQx0F0adryIgZjbGVLdX/rZNAd5uat9Fveo qNr//mrZrlh1yUqPMjAxaB9M66waJki0qInLHxtYz8955VcG98N2Y9/F0XSeWj3AI1M+ H4Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=11MI0KiTsfDovJmHLIZ6mGMd2aO/GNiEEd0QOHNHXg0=; b=AtSlh+IIN6MFEJYMt456fVKRr+kqg6Ys+Cv+gx0kfxQgdD7v9fVKFoXu7ZSOrLSeDT 5pUYtVLL5Zekzo2R5KCLCmxb9n2DzoMZaCDtxocMerVkrIAcci95JHKm+Gf+5003CMY2 5paD4zesp8h5xraBLi1Ek2YLNNscqfQ5tTSsPkUBuDR38q1OIZho4usuO9MaMNwJ442s RM14tcLtvvVQ5MvD3YG/qDYPJzvTrxoKVKp0z7uheZa2ygYvO1YcVW3weNoANg4TN+HC eUU8kp5XcvIImeA21nZnnfQ7U440LZmfF6y8ACLG7puflnQiTifXMMX3HZFQ60sHdcMS x2Gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tessares-net.20150623.gappssmtp.com header.s=20150623 header.b="Yc1/H8ef"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t7si1953600edt.107.2020.09.09.10.17.53; Wed, 09 Sep 2020 10:18:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@tessares-net.20150623.gappssmtp.com header.s=20150623 header.b="Yc1/H8ef"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730303AbgIIRPa (ORCPT + 99 others); Wed, 9 Sep 2020 13:15:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730212AbgIIP3F (ORCPT ); Wed, 9 Sep 2020 11:29:05 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21494C0612F8 for ; Wed, 9 Sep 2020 07:39:58 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z1so3254573wrt.3 for ; Wed, 09 Sep 2020 07:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=11MI0KiTsfDovJmHLIZ6mGMd2aO/GNiEEd0QOHNHXg0=; b=Yc1/H8efLlur4NsZLckZuVxVv7eBKW+pOWMidUFk8KtU0BAoPVPXWk16J5mKnNrmIi oWB20T+Z2wVlAeFQT3uhLlx8nm1qKbo+/rKT870Cni1Y1rvHVkbmASg+/AfCDUB8dHFb TLVHSYXSJi6UFU0cTS/U9tEbHBhBLAjxYjnFM7MYgQNxIJtG4KvvC38iEKyftKrY9H+1 HSx0E0vxEPJhDXm3VLoD5HTSk56PQ8Z3oow2H9NPpBHJXjDQQLsyXgx6lPJRPrPZoIQc adu/KyZfOH0QEy/Tx3fMUNsu8auumg3t/aka3gUOr2/dPsvtlMe+R4Te4NvYpDU6Qx1s Hzag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=11MI0KiTsfDovJmHLIZ6mGMd2aO/GNiEEd0QOHNHXg0=; b=fOuNhqOT2Q9vq2xown16l1V6FfgKvOTFSngkEaL0aPnzL47BJnTf6/oJk6PVm9kx37 Ip5Zd3l22G89n9vblcg4+wIjE3UuIg0GcvICgQvY9cPCnXvNXR5r19q0uSGi605iPteK 1prwtfHs76mB3OvZO+pCpgfqlj/G9ugIqjXdLjAHXk2s6DnP4Jo+q1TqvZj5ISknaq0i 7z/Rljdr7xfApyVVMQvnpumLNLmSgqCrOUAdF+k2yZYCBW4Ed8dXKZxZhBdr56Q+KDRK GB1cz1fgCin6hta2Z5znOpJl3qJVhuPUyaKh3zux2ErNAeSohT6bHnIt2G/tKpYCa7lJ KdVQ== X-Gm-Message-State: AOAM531eVe1f6iiX+4TtsdsHasDWV0K9j3mqAz6+dkjp74KQp4ejP4o0 VLMpxLyfQJE4oq/jpsYST9c7zVYZNtMIAw== X-Received: by 2002:adf:edcc:: with SMTP id v12mr4240797wro.240.1599662396424; Wed, 09 Sep 2020 07:39:56 -0700 (PDT) Received: from tsr-lap-08.nix.tessares.net ([2a02:578:85b0:e00:8ddf:bedd:580e:7a7e]) by smtp.gmail.com with ESMTPSA id z15sm4368511wrv.94.2020.09.09.07.39.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2020 07:39:55 -0700 (PDT) Subject: Re: [MPTCP][PATCH v2 net 2/2] mptcp: fix subflow's remote_id issues To: Geliang Tang , Mat Martineau , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Florian Westphal , Peter Krystad Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org References: <0127c08400bdf65c03438b0b6e90e4ab72ea1576.1599532593.git.geliangtang@gmail.com> From: Matthieu Baerts Message-ID: <4c6c23fc-f493-ce9e-953f-679109de5fc8@tessares.net> Date: Wed, 9 Sep 2020 16:39:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0127c08400bdf65c03438b0b6e90e4ab72ea1576.1599532593.git.geliangtang@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geliang, On 08/09/2020 04:49, Geliang Tang wrote: > This patch set the init remote_id to zero, otherwise it will be a random > number. > > Then it added the missing subflow's remote_id setting code both in > __mptcp_subflow_connect and in subflow_ulp_clone. > > Fixes: 01cacb00b35cb ("mptcp: add netlink-based PM") > Fixes: ec3edaa7ca6ce ("mptcp: Add handling of outgoing MP_JOIN requests") > Fixes: f296234c98a8f ("mptcp: Add handling of incoming MP_JOIN requests") > Signed-off-by: Geliang Tang Thank you for the v2! Reviewed-by: Matthieu Baerts Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net