Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp528694pxk; Wed, 9 Sep 2020 11:32:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEKdEHxv+o+AXnWIb8cgOkFkB8Qz6Ikrvo4CHTlmOjca2MuvfDk5kQkfF0P7TvOcVL/FWn X-Received: by 2002:a17:906:390d:: with SMTP id f13mr4942483eje.86.1599676341052; Wed, 09 Sep 2020 11:32:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599676341; cv=none; d=google.com; s=arc-20160816; b=fzQKyXCDhLCtaZayE/2Bh7twXJMTP87LVjL2PWImcAYfQq9A4dQuB49rjXRM+J+cFB CArB9MtAnTvY1cGzaiDgSzXWSOqUI8CS8JiqeK234njpPKD2ZYHUUkzxIrIftNxL6EUl 00XxOLdFdLLfz9g+cR3CqX3GTGs8fO08bt28j0oQO4Zl4aLa/cgjOyHzRg5VoOmBu1Er c7IRxgQfN+0mCCEOAiLm+0OzZ1pUhztp8TdU8HbYrDQQ2/2vLroPAzg4uy+n80+Es0N7 FAJhIRbnN2uCn30Xrbdwsee2QYZwNlvoid+Pfi31ewbutS65zP3C6a1ZdsZSIsHbvH/5 9Y8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=98xyvtYgbwa5J67c7RkI6GnQwliGFXe74W0JhOQBOmc=; b=KDweL+BPf9a59yVO3FJjbOEo4jQN0jE2cXSguLPlG5Y3DDwWcO359ETpzYneix5iLm FeT8sLIIR1R+vucuQjwR96d54qOE6lK253lfNookx9nr4zFU1lFVwsOeDxSaDETOUYDo XNQ+ZoSTaZjP9N8KY16nPKWlXAMIN2ndaTYVusAw5pDg35vfdO6kfmtX6lBwYvLeWKkk EiEgRzwihAlghaSLUWcp5VmQaNCc8kXtZ+GA7U1s9TZleTGttB+DezpgBWUEidGLivnn ayOGXrwbQaHs0sbW/77CRd9zLkbdtZW60WINKYlhxNvuRc8bFXZfrmFzw2Q5yX6Qcszr qUWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Aai15vFl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 19si1937306ejz.498.2020.09.09.11.31.57; Wed, 09 Sep 2020 11:32:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Aai15vFl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728405AbgIISat (ORCPT + 99 others); Wed, 9 Sep 2020 14:30:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbgIISar (ORCPT ); Wed, 9 Sep 2020 14:30:47 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 906A9C061573 for ; Wed, 9 Sep 2020 11:30:47 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id z13so4238234iom.8 for ; Wed, 09 Sep 2020 11:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=98xyvtYgbwa5J67c7RkI6GnQwliGFXe74W0JhOQBOmc=; b=Aai15vFl3dYqGw9K5b3xK4POAF5zorYpaKKRyIxIZqV4MkjapQJdc5WoBCxIdDvoQe 7FdlRAedwzY1qpqwlJ5d+oVkEoZFtbyilOo5PeMvP4vfl//XjFD28AIWbmbRXihnb49x JbVoj7qo0eWkzJVqnZ3EfR9rqCRwG9dCMJoxkLi4ToOLHhfZC3SzjOM+82YB9SjmG1R5 a33hxHQK4Io4do/ldHL0Nwp+Us6ESgUxv94eNJDwEE8kOAIZj98CWh42I5BQfrPOtm/D GfnSrPywZHKaSWgiqluDNEtHluhP8WGr1YnzmI21OdCOYBTano9T1NdzUMKvE3YznXEE +6HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=98xyvtYgbwa5J67c7RkI6GnQwliGFXe74W0JhOQBOmc=; b=QAOtj/4J6Gt+ULM+QO7Ccggujti5QCKGsobs5739Ch/RNn+FNsTG2XNgqHvLoiP36E 9zVxTeoIvn5YxAQ6ff7TpkB8ytE+YudhkfZl5l5t4lADN+wCSSBVd510rrd4PLyXEl11 wAuEQwrEHavHN6VBCWrfv79IT39NekNlklfeOK0INK1HX5lWpXM/K0NxkPILG0hN9l/+ 9l5Qn4ThRDEgzpFV1MfX0mBVZJvg1RVkzHEMb7PdLolcvGw1a10Z2wzVeBgkqj2A/sE2 eBAFjuQJCIYuEpZ873J8wE27yjjGGu1f8x05SfpdWCVQS/jzKb3N2S5a+QolSy++AlMU ZH7A== X-Gm-Message-State: AOAM533W8HBTV2aaPswQk94yYNYqBYmf2/2Kengn5Nx9co0Vf7hMyhTR /Rxnt4gzHWDjlklhCsO2Uf5+4A== X-Received: by 2002:a05:6602:2f88:: with SMTP id u8mr4410307iow.175.1599676246841; Wed, 09 Sep 2020 11:30:46 -0700 (PDT) Received: from [192.168.1.10] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id u9sm1501725iow.26.2020.09.09.11.30.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2020 11:30:46 -0700 (PDT) Subject: Re: [PATCH for-next] io_uring: fix ctx refcounting in io_uring_enter() To: Stefano Garzarella Cc: Alexander Viro , io-uring@vger.kernel.org, Kees Cook , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20200909151900.60321-1-sgarzare@redhat.com> From: Jens Axboe Message-ID: <9080c3fa-a726-b664-f634-0ea7dfda80e0@kernel.dk> Date: Wed, 9 Sep 2020 12:30:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200909151900.60321-1-sgarzare@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/9/20 9:19 AM, Stefano Garzarella wrote: > If the ring is disabled we don't decrease the 'ctx' refcount since > we wrongly jump to 'out_fput' label. > > Instead let's jump to 'out' label where we decrease the 'ctx' refcount. Applied, thanks. -- Jens Axboe