Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fs: omfs: use kmemdup() rather than kmalloc+memcpy
To:     Bob Copeland <me@bobcopeland.com>,
        linux-karma-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20200824211755.597245-1-alex.dewar90@gmail.com>
From:   Alex Dewar <alex.dewar90@gmail.com>
Message-ID: <5efaa7be-1890-0169-d133-8dd40b238d6d@gmail.com>
Date:   Wed, 9 Sep 2020 20:04:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200824211755.597245-1-alex.dewar90@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 24/08/2020 22:17, Alex Dewar wrote:
> Issue identified with Coccinelle.
Gentle ping?
>
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
>   fs/omfs/inode.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
> index b76ec6b88ded..8867cefa79cf 100644
> --- a/fs/omfs/inode.c
> +++ b/fs/omfs/inode.c
> @@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
>   		bh = sb_bread(sb, block++);
>   		if (!bh)
>   			goto nomem_free;
> -		*ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
> +		*ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
>   		if (!*ptr) {
>   			brelse(bh);
>   			goto nomem_free;
>   		}
> -		memcpy(*ptr, bh->b_data, sb->s_blocksize);
>   		if (count < sb->s_blocksize)
>   			memset((void *)*ptr + count, 0xff,
>   				sb->s_blocksize - count);