Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750939AbWE3Lz5 (ORCPT ); Tue, 30 May 2006 07:55:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750930AbWE3Lz5 (ORCPT ); Tue, 30 May 2006 07:55:57 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:10459 "EHLO mx2.mail.elte.hu") by vger.kernel.org with ESMTP id S1750925AbWE3Lz4 (ORCPT ); Tue, 30 May 2006 07:55:56 -0400 Date: Tue, 30 May 2006 13:55:45 +0200 From: Ingo Molnar To: Jiri Slaby Cc: Andrew Morton , linux-kernel@vger.kernel.org, jgarzik@pobox.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, alan@redhat.com Subject: [patch, -rc5-mm1] lock validator: remove softirq.c WARN_ON Message-ID: <20060530115545.GA7025@elte.hu> References: <20060530022925.8a67b613.akpm@osdl.org> <447C261E.1090202@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <447C261E.1090202@gmail.com> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: -2.8 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.8 required=5.9 tests=ALL_TRUSTED,AWL autolearn=no SpamAssassin version=3.0.3 -2.8 ALL_TRUSTED Did not pass through any untrusted hosts 0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 44 * Jiri Slaby wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Andrew Morton napsal(a): > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm1/ > > BUG: warning at /l/latest/xxx/kernel/softirq.c:86/local_bh_disable() ok, that WARN_ON is over-eager. Fix is below: -------------- Subject: lock validator: remove softirq.c WARN_ON From: Ingo Molnar there is nothing wrong with calling local_bh_disable() in irqs-off section (as long as the local_bh_enable isnt done with irqs-off), so remove this over-eager WARN_ON(). Signed-off-by: Ingo Molnar Signed-off-by: Arjan van de Ven --- kernel/softirq.c | 1 - 1 file changed, 1 deletion(-) Index: linux/kernel/softirq.c =================================================================== --- linux.orig/kernel/softirq.c +++ linux/kernel/softirq.c @@ -83,7 +83,6 @@ static void __local_bh_disable(unsigned void local_bh_disable(void) { - WARN_ON_ONCE(irqs_disabled()); __local_bh_disable((unsigned long)__builtin_return_address(0)); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/