Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] w1: Use kfree_sensitive instead of memset+kfree
Cc:     Evgeniy Polyakov <zbr@ioremap.net>, linux-kernel@vger.kernel.org
References: <20200909194122.212486-1-alex.dewar90@gmail.com>
From:   Alex Dewar <alex.dewar90@gmail.com>
Message-ID: <534193cc-24be-592b-0713-1973bbb0217f@gmail.com>
Date:   Wed, 9 Sep 2020 21:30:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200909194122.212486-1-alex.dewar90@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-09-09 20:41, Alex Dewar wrote:
> Issue identified with Coccinelle.
Hmm, on second thoughts, I'm not sure this memory is so sensitive after 
all. Should we just remove the call to memset?
>
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
>   drivers/w1/w1.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index e58c7592008d..4f597b0fd1da 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -71,8 +71,7 @@ static void w1_master_release(struct device *dev)
>   	struct w1_master *md = dev_to_w1_master(dev);
>   
>   	dev_dbg(dev, "%s: Releasing %s.\n", __func__, md->name);
> -	memset(md, 0, sizeof(struct w1_master) + sizeof(struct w1_bus_master));
> -	kfree(md);
> +	kfree_sensitive(md);
>   }
>   
>   static void w1_slave_release(struct device *dev)