Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CABXOdTdYJs4_nS=Oj5J=_Y0Q34Uo_i0mY=KKkr0PvUOjOOxG-w@mail.gmail.com>
References: <20200909202609.1630698-1-swboyd@chromium.org> <CABXOdTdYJs4_nS=Oj5J=_Y0Q34Uo_i0mY=KKkr0PvUOjOOxG-w@mail.gmail.com>
Subject: Re: [PATCH] platform/chrome: Don't populate lightbar device if it isn't there
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Gwendal Grignou <gwendal@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Lee Jones <lee.jones@linaro.org>
To:     Guenter Roeck <groeck@google.com>
Date:   Wed, 09 Sep 2020 14:01:20 -0700
Message-ID: <159968528004.454335.687873020977684163@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Guenter Roeck (2020-09-09 13:48:41)
> On Wed, Sep 9, 2020 at 1:26 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > -static int get_lightbar_version(struct cros_ec_dev *ec,
> > -                               uint32_t *ver_ptr, uint32_t *flg_ptr)
> > -{
> > -       struct ec_params_lightbar *param;
> > -       struct ec_response_lightbar *resp;
> > -       struct cros_ec_command *msg;
> > -       int ret;
> > -
> > -       msg =3D alloc_lightbar_cmd_msg(ec);
> > -       if (!msg)
> > -               return 0;
> > -
> > -       param =3D (struct ec_params_lightbar *)msg->data;
> > -       param->cmd =3D LIGHTBAR_CMD_VERSION;
> > -       ret =3D cros_ec_cmd_xfer_status(ec->ec_dev, msg);
> > -       if (ret < 0) {
>=20
> I am quite sure this conflicts against the patch series I submitted
> earlier, specifically "cros_ec_lightbar: Accept more error codes from
> cros_ec_cmd_xfer_status".

Thanks! A pointer to git commit would have been helpful to find it even
faster but I got it now. I'll rebase and resend.