Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp656832pxk; Wed, 9 Sep 2020 15:33:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbKdD/Z8ymib2E2/K8d/YfrBcrnM7qiouHwnxcP107vCanq1DXKwVMMblS5qg/G59/7cI+ X-Received: by 2002:a17:906:22c1:: with SMTP id q1mr5626983eja.529.1599690787813; Wed, 09 Sep 2020 15:33:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599690787; cv=none; d=google.com; s=arc-20160816; b=O+BRaMAU5uafq4vxMCOmPDUKKtGsvwcRNf9TdDZJhocn8QoA9H8M+psGunpzl/rDRY IZjcueiSVESD3QiP03cmY5dGNL0MeJ8M8e+jAe+RoqJ9xf6zOAOpBvFz9W0IrR0jwimT 2KHhmcEKzOUjBHKuc0faBa4grqgAWtJUzVLbCr7xY6W5prKKyVT272P7hfb3X2HfeT3h b0+24v4+XanBELgSpyEn5D2pP1+L0hhkuFuR3WkLO4dNZAhhkGDazkBeNbyCLRSHLOB+ iYULWA3tsq2BgLg5O6CCakoKfIOpzxufz629rDzYpYlFxGgr3xnsDgi216LqIgclQ3Bm ZXCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EtoAvOurFFZP/gUt2lOxm9is7YQr4gyUFJI+eCbp8z4=; b=u31y8pOwh7PxL3Hdrme0ZqA929lPzZ3tY6Q/PY24OVQSYtYW7ZZF2+22MRc+GNewsY GG5amz/JYCGdQWJ9zLIjszyqm3+g4yUG/D2ajma37mTA1+L/iB0MyzUt9skCFEg1YN/0 2AAkXpLvAdfmqd7IsfZnUWzbev0pxDTDxcLy9WfBCz9Ix6/B5T027nY4AgUzvL6p9yMd VVpb1hM6XPpqnQPla3432jY9vAVqRKbfSdvR4tEf0rcjdO6asyys13WtzsWSeHbYl6nb dKcp4LejwLDeAfH2gwBxUog8QvZ26rZkfcncOcWllvnSszWQ+T5rwcb5ooefngrULpil dUnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nncUTurk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si2446305ejy.245.2020.09.09.15.32.44; Wed, 09 Sep 2020 15:33:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nncUTurk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726714AbgIIWcA (ORCPT + 99 others); Wed, 9 Sep 2020 18:32:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbgIIWb6 (ORCPT ); Wed, 9 Sep 2020 18:31:58 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6D4C061573 for ; Wed, 9 Sep 2020 15:31:58 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id a9so2044770pjg.1 for ; Wed, 09 Sep 2020 15:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EtoAvOurFFZP/gUt2lOxm9is7YQr4gyUFJI+eCbp8z4=; b=nncUTurk+QTmh61R5oSwO5R5vYFaOtQwsoT1xsoDlKIM4Bisb51TEz43D09Ty9brUU EeE2JTcVrDeGt/IOKdBZAku5MwinwMy0rXaXhTuJrZNDBT5oNPlMwdlCn06bzjj7WdNW fc3JeZEvrCgrQTn8CjWa7r01EYq0SAsqNE8Ow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EtoAvOurFFZP/gUt2lOxm9is7YQr4gyUFJI+eCbp8z4=; b=XTgyLuI171G4yfLgA5b3srXojWCpztd/wMVyCZnBtGmAFarXfeAnzy3ykccApPB+O3 6VREEXGZyLumR+RMxj4XRn53pEPK46UQ23zKhsapvjqO+QBggXwnxQh0VEZYcavBbmV3 NQWWQY8/Yg3IN3DPlyEiVY1Afv2BL7yNAXNM97kA53iwFEbcjnQ85IGYlY8QxdDgH+/o q8YookIuPKbG47COk0OQKi/gcI9EVzq1/MKgzUc6qfxuBb7Pnyknqt71zGzdlro/aQoe Qv2LE1UCHJlUgDhpqvYZbf/QL9N+wlYGR4zeHTWq7uyXUF2xlskOlgTcsACZ9BLQfJbX DEJA== X-Gm-Message-State: AOAM5301n7WEL13QC4xhL7QY2UBvXwp2Od4zSMz0v9S7tHNFpIvSV0K4 hmyH+hEDyE6G9PAhNIM+bnWrMw== X-Received: by 2002:a17:90b:a4b:: with SMTP id gw11mr2462960pjb.37.1599690717790; Wed, 09 Sep 2020 15:31:57 -0700 (PDT) Received: from localhost ([2620:15c:202:201:9657:a5ff:feef:7b57]) by smtp.gmail.com with ESMTPSA id u14sm3826433pfc.203.2020.09.09.15.31.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2020 15:31:57 -0700 (PDT) From: Sean O'Brien To: Joe Perches Cc: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, LKML , Sean O'Brien Subject: Re: [PATCH v3] HID: add vivaldi HID driver Date: Wed, 9 Sep 2020 15:31:48 -0700 Message-Id: <20200909223148.419843-1-seobrien@chromium.org> X-Mailer: git-send-email 2.28.0.526.ge36021eeef-goog In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > if ((parser->global.usage_page << 16) != HID_UP_GOOGLEVENDOR) > return; I'm a bit worried about adding an early return, as it may cause issues if someone doesn't notice when adding another case. Looking at this again I can easily remove the second line break now that I've changed the group name.