Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp830832pxk; Wed, 9 Sep 2020 22:35:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUAdr17r7aaC0yx6MXcuTfGzEFUG3CawJ4L9oyBAFvwTu6q3of/aeLrpJFlERENTIS18V8 X-Received: by 2002:a17:906:4305:: with SMTP id j5mr7376479ejm.102.1599716122307; Wed, 09 Sep 2020 22:35:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599716122; cv=none; d=google.com; s=arc-20160816; b=CNIHdbXjya+UVHScrBE2Izq3Episv8mkdqBq89g1NolamRI2CnZlHbxQkrKfatF7mD nAYQMB/RXQyf0NJnUZBuMvWeYi6dS0xjh2nPiU911M3S9a64Z5mAYnHQ3kdpt+hmTvph YTb65EPSQYlIx/CJvAJv+nd0iBVyxECdxKZnQmOCifkJFJeeIYMFQ3+RURaaSngCQZDu nzSMaDPhOs99RI+lNa6iHcsLp27gUazdN0mnostQ6CTxNbckbafZFTiy5Rro6BAskkJA GPv73IIcDrIbwamYnRxcort46pv34GIVHX9/zJ1SfAgBqEBO2mPQnDm385LLfw6RRxTn 066Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=60m4hlTxGIMTHH9zDLpW2r5D85YdOPl2w4joQJnWmwA=; b=k87sLvT7Cjfd74YevWkWp+0FbprC6gDuG8oJ9wHXLdtBokoBIDno9/ceG5YQkR1sAD 4MFxfMGXm1OjVLM7beemZbQ63M6Jh5fiR2RmO2zZ/GuNIwYw5WCYPnF9buuaZ1+x87x2 3g0qSD2VMNOKsf0lUV3r0xXoBxSfd2HOYp929wutzp7YsvJninOu5bGJ3s9F3NtH1IKH IaCwIKI7E1zzVXBJ6pUK8qBCPSujp8c865ChoeC0G7vhO6kLvXZyGbN79+JX6sM74Mio sUFFUfbA+cO8zVUYdj4GJZgXyVg4q0IlS86H4p00OaIlk8/ef/WGWTBTmkqglEPKoCO+ RRjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="nY/GFWKy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s2si2706981eji.538.2020.09.09.22.34.59; Wed, 09 Sep 2020 22:35:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="nY/GFWKy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725992AbgIJFeO (ORCPT + 99 others); Thu, 10 Sep 2020 01:34:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgIJFeF (ORCPT ); Thu, 10 Sep 2020 01:34:05 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64FCBC061757 for ; Wed, 9 Sep 2020 22:34:02 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id i1so5023334edv.2 for ; Wed, 09 Sep 2020 22:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=60m4hlTxGIMTHH9zDLpW2r5D85YdOPl2w4joQJnWmwA=; b=nY/GFWKyeBX/RUFO9u1oe4hlkrj2e2sOr59SOi/XTYi5toZj9oU+PlC3yWoAwPOFN2 5i8xIU1YcBt2bAXr6Jp03/gOrEuZTChoV6Eg6JR+z8Bb75FlyvBxuquNU7tXif2hK8k0 bJKTYNsTwz5EUDsp6fTOQJvRuIvC1csiVVvzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=60m4hlTxGIMTHH9zDLpW2r5D85YdOPl2w4joQJnWmwA=; b=lYtDvgAgmeS/g/2aodkQP/Tlkf6igLbtucGIG9aGcFpUjWVE6JxBOP3oT9X2/ppSiQ wORmnaMLDD+ap4isC6rplo4znpwkr2CyM3+aQsdivV9If72iuYePJy08ZpYSD4hH6CRh zSoQ5kvUOlAfYYx4Xm2IQ+CiAMB3k656vxb9pjyHZaMOE0IRc6nxI3HvdNlybsVI/yv5 U+gJlmUO+duqU5FQFGGv/f0IThtMRfK9aMKXVXY0rhVuj9MUPFAJYVU1b5MEi7fWeKwj 2CIdbNv+O8jk/ZZsF21c/X9rFJjphkvKx/DytJZfBuJR2nwgyR4jfuiT6age2fNpGSan pY1g== X-Gm-Message-State: AOAM533GyiPVyHbhEcE8i91r07KUW0ypo2dUZgIA0Rs1ZkVSmR0z7oPU OHDQ1GOYknrurotbuJCDL4c3G5nDIzlzaYV4jX3B/w== X-Received: by 2002:a50:fe0f:: with SMTP id f15mr7513034edt.235.1599716040960; Wed, 09 Sep 2020 22:34:00 -0700 (PDT) MIME-Version: 1.0 References: <20200909081422.2412795-1-pihsun@chromium.org> In-Reply-To: From: Pi-Hsun Shih Date: Thu, 10 Sep 2020 13:33:24 +0800 Message-ID: Subject: Re: [PATCH v2] arm64: dts: mt8183-kukui: add scp node To: Matthias Brugger Cc: Rob Herring , Eddie Huang , Erin Lo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 9, 2020 at 4:58 PM Matthias Brugger wrote: > > > > On 09/09/2020 10:14, Pi-Hsun Shih wrote: > > Add scp node to mt8183-kukui > > > > Fixes: 0d5e41709f76 ("arm64: dts: mt8183: add scp node") > > Signed-off-by: Pi-Hsun Shih > > --- > > > > Change since v1: > > * Add Fixes tag. > > > > --- > > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 30 +++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > index f0a070535b34..85f7c33ba446 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > > @@ -90,6 +90,18 @@ pp3300_alw: regulator6 { > > regulator-max-microvolt = <3300000>; > > }; > > > > + reserved_memory: reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + scp_mem_reserved: scp_mem_region { > > + compatible = "shared-dma-pool"; > > + reg = <0 0x50000000 0 0x2900000>; > > + no-map; > > + }; > > + }; > > + > > Do we expect other boards to have a different memory reservation? I can see that > EVB and Kukui uses the same. If not, we should add the node in mt8183.dtsi instead. > > Regards, > Matthias All our current boards use the same memory reservation, but it's still possible for future boards based on mt8183 to use different SCP memory size, so I feel this should still be left out of mt8183.dtsi. > > > max98357a: codec0 { > > compatible = "maxim,max98357a"; > > sdmode-gpios = <&pio 175 0>; > > @@ -524,6 +536,13 @@ pins_clk { > > }; > > }; > > > > + scp_pins: scp { > > + pins_scp_uart { > > + pinmux = , > > + ; > > + }; > > + }; > > + > > spi0_pins: spi0 { > > pins_spi{ > > pinmux = , > > @@ -651,6 +670,17 @@ pins_wifi_wakeup { > > }; > > }; > > > > +&scp { > > + status = "okay"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&scp_pins>; > > + > > + cros_ec { > > + compatible = "google,cros-ec-rpmsg"; > > + mtk,rpmsg-name = "cros-ec-rpmsg"; > > + }; > > +}; > > + > > &soc_data { > > status = "okay"; > > }; > >