Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp850059pxk; Wed, 9 Sep 2020 23:22:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQGRWOcn9EPa0UGLXCO4q1hImu8oTV72VJULWr/smYWGgw31+tIl0bCtCDcvwyhKF/87Bp X-Received: by 2002:aa7:c419:: with SMTP id j25mr7808822edq.109.1599718942111; Wed, 09 Sep 2020 23:22:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599718942; cv=none; d=google.com; s=arc-20160816; b=bIqMlH/b52tC5Oc8psI+TBEnfuQGkJm0kiSXUXZHZJA/H6R0Ql4FV/8FI8XKecy61+ du+Ky94dAdHnWmZN7joSHDyVsS7ZpOa6jsMLSpRXHBNyDV2EobXh1uJ4TKCgoZtP7uMw iwhj6aEqJSsXwfrhqXY/JEPmYkP794KzBBKbV6Ti92bf6j4HMvZeLSfS9Mgj4N4f/nvD 02Ni6O2KDKdGiSGIzWTn/1m3T5na0jsXqvrh0TL3D1fvQ9+NPQD8A8OD5ruMkMgtY+7S 0afhPaa2pL8qm4JCUg5qdlQJaQzqRcaf+47HmYoY+cNq71TYfItMLXjwhnbFCIjnoqXc 5PYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JWNUxWZbGJJ1fihwnRRpBTK9XQnFPsAPD0+ab1fseg0=; b=SleF0d/jUMf+KKogI6fRp58iV2D4QMu44rpW26G/oq5ZQyKyjN0uZCyAtw7mmd0zYV 2nc2yiq19S0V5aeNNagLqgIN+hhpfCfZOB4pfCCheK3XHJqExvShvxpLv2WIF/Tm/JRV nggEG0bwZ2PblHnF6nT4CD7vFFnOYKijnsI/3paiQdBZGeOT7Fz7mPicff9NGF9S9Xs4 ILNtgoVyVZdi4MGaN0LERmfTJANb/+7L7g5eH9bnr0H60Fn2PQaGSjx9fh+gX5kZJP1l WlYHfhgc9BKLGSUA4i3wxUwOgYtOiZURVbQ2TMle2cFLTwNQ8ipop84uZzmHWfChew3t JxFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fbiWPiLG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si3060434ejb.217.2020.09.09.23.21.59; Wed, 09 Sep 2020 23:22:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fbiWPiLG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbgIJGVF (ORCPT + 99 others); Thu, 10 Sep 2020 02:21:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:48470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbgIJGVD (ORCPT ); Thu, 10 Sep 2020 02:21:03 -0400 Received: from localhost (p5486ceec.dip0.t-ipconnect.de [84.134.206.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BED97207DE; Thu, 10 Sep 2020 06:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599718862; bh=JWNUxWZbGJJ1fihwnRRpBTK9XQnFPsAPD0+ab1fseg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fbiWPiLGCvPfrqWWZo5JFgb0/Uw26pu9zVq68ZQqhDRwSWZe7agcZkOIx1SnYzMrh hnkhvpGayepHpld0KmFCoOuDnFXWPZ3SrV6glb+8+a81MN0AIqWOSVgFBX+/2a7T7+ cFq8vyvDSlE68w43+QHICEgzMmKiGQGYDpZIWA38= Date: Thu, 10 Sep 2020 08:20:58 +0200 From: Wolfram Sang To: Eddie James Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, dmitry.torokhov@gmail.com, joel@jms.id.au, andrew@aj.id.au, benh@kernel.crashing.org, brendanhiggins@google.com, rentao.bupt@gmail.com, ryan_chen@aspeedtech.com Subject: Re: [PATCH v3 3/5] i2c: aspeed: Mask IRQ status to relevant bits Message-ID: <20200910062058.GC1031@ninjato> References: <20200909203059.23427-1-eajames@linux.ibm.com> <20200909203059.23427-4-eajames@linux.ibm.com> <20200910061813.GB1031@ninjato> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="adJ1OR3c6QgCpb/j" Content-Disposition: inline In-Reply-To: <20200910061813.GB1031@ninjato> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --adJ1OR3c6QgCpb/j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 10, 2020 at 08:18:13AM +0200, Wolfram Sang wrote: > On Wed, Sep 09, 2020 at 03:30:57PM -0500, Eddie James wrote: > > Mask the IRQ status to only the bits that the driver checks. This > > prevents excessive driver warnings when operating in slave mode > > when additional bits are set that the driver doesn't handle. > >=20 > > Signed-off-by: Eddie James > > Reviewed-by: Tao Ren >=20 > I reconsidered and applied it now because this helps whenever slave mode > is used. So, applied to for-current, thanks! If someone could provide a Fixes tag, that would be welcome. For me, not knowing the HW it doesn't look trivial to determine. --adJ1OR3c6QgCpb/j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl9ZxckACgkQFA3kzBSg KbZ3iA//cQfh41pbKdqYAo099C5IRm15SZnDi0WxKZpIYlYR22XokN01zfTYj/vX AIy+9J85UNFbLBhrASWn/Zuu7/4VkAKQgBPZChEH6EJ4wRe9RGHg6+Em21n0gqR9 pyWNMkX4S/iSeLdhsi0HZ23Lg9KyN8tFUiw1Wj4DCcQGEDe8W1oOBkW1X1r2YLTk p99q/blvdOcfPUqfSFRxBYCKFYwipTllZMAklQ52sHDKpabgIxdNtUsffSrZaabr 4UNtkX4cf+S5KZb87uXXb3zeVFRpr/tls4CQDAMyJHiqvrMT9gLGmpmKAX93RDy9 dln32Q1uJbhiTjQc/tTuxQiiCiexc0vpk0uf1yliEbToVzb7rLCXz/ms9sY+oPZM tOzbG8/ERYdkUAbdkMIrgASNgDgrQvISH8pyLIIGfrGsiz2FcFBHUCBCONeyZgR8 kndwyqr0plUr0RsCibBkkyRRKT/D9SkJAAMDBaAg68j2Uj+PEr+ccagf/AH+Fdbb gTLE64Mx1awSmGF6RpOHEgvEG+o62GDbZk/TmKD7GIWjeXqpZwoG1OySHc/gmFrJ lB4SN2kjxbHhcOB+D0YatsuVmrwEbQFTMMTH01gWjwLRpjNQ9TOxrMgmOhtiMyh/ C7jkwvhOCiwtvd5zmD2JTn7r/0GhZXU6dg3DLlZQzMsh9NhV45s= =24Fn -----END PGP SIGNATURE----- --adJ1OR3c6QgCpb/j--