Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp888554pxk; Thu, 10 Sep 2020 00:54:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweZSXqRfAqJGPhCK4F1hhAXFmNWnUNmLQ/VKMl2tZ26chLhzejU1ARCrV1fQuclVfBA252 X-Received: by 2002:a50:e78f:: with SMTP id b15mr8061155edn.104.1599724448353; Thu, 10 Sep 2020 00:54:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599724448; cv=none; d=google.com; s=arc-20160816; b=fyis0EEOutAtfb/KmsNkQqdjr4VJWoF9yHahijFOI44SqS19VmSPJpnr0A/Zpsqnoq Qbe6aI+YRZwoYspjm1NH0nruypmKyqphKTkK07Z/k79QOXdAeoJMV0BToE+oiIc2+kD4 QTfKf76RSfCvZOytWpGoJ+2s6DvaITFIugpmgavOrdFS40r1cautjYw/VJCDF+otQBSi KX35t2QATbQrM4Wk93rALseqtCqZdH8O0Kxlc9mudsvL09/DemWz+c3yR0uLPXXCXhzO K8uX4yF+/7yxwZ/DJstNbmEPLYGnRZ6r997nVXP6zu5Qb2LmNTfKOgumtLl2m1q5ryxR /O5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=AR2OTRsY1F8bFAKy1jm0yfCPyeQDLxyiHXykyqIyJac=; b=x659k3jNLDEAurbkuHtNKwiO9IgHNZICCQCckxi8lEx77bmA1FmsSwlQuJS3CF6JWb 38qrcdUmXzq4UoQ7ACb56pDPejUS1Vlh5taPzdinCDoel+Exc5A1UVLQDT6zJ11z+qh+ V3Us2JLZoI5dZxg+wtM9nHuweNTX5KtiqxIVU3x1cZtQUYMqS2qG+dgx3ClYgtCE8Qqq IVMfE/FexNsPjNOQb98hbCEx2rLWGjXf1Qkp3L4/+FVd2MyEbKzaewYfRinzS7ZKqnYZ S8N8J0a9qet6M8/+PT0ZRlPwnXlRJrGRO2cXE4rs35cbDCBqi51UdYEWQXVv78STF6Fb v4tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si2881075eji.422.2020.09.10.00.53.45; Thu, 10 Sep 2020 00:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729911AbgIJHwy (ORCPT + 99 others); Thu, 10 Sep 2020 03:52:54 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:48412 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726228AbgIJHww (ORCPT ); Thu, 10 Sep 2020 03:52:52 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id F28D11EF2D70231AC517; Thu, 10 Sep 2020 15:52:50 +0800 (CST) Received: from [127.0.0.1] (10.174.179.108) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Thu, 10 Sep 2020 15:52:49 +0800 Subject: Re: [PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_core_suspend/resume __maybe_unused To: , , , References: <20200811021225.50296-1-yuehaibing@huawei.com> CC: , , , From: Yuehaibing Message-ID: <7b9799c6-96e2-2273-a296-ea1a94e4cade@huawei.com> Date: Thu, 10 Sep 2020 15:52:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20200811021225.50296-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping... On 2020/8/11 10:12, YueHaibing wrote: > If CONFIG_PM is not set, gcc warns: > > drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: > warning: ‘cdn_dp_resume’ defined but not used [-Wunused-function] > > Mark them __maybe_unused to fix this. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > index a4a45daf93f2..413b0e90f10f 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -1107,7 +1107,7 @@ static const struct component_ops cdn_dp_component_ops = { > .unbind = cdn_dp_unbind, > }; > > -static int cdn_dp_suspend(struct device *dev) > +static __maybe_unused int cdn_dp_suspend(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > int ret = 0; > @@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev) > return ret; > } > > -static int cdn_dp_resume(struct device *dev) > +static __maybe_unused int cdn_dp_resume(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > >