Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20200829175704.GA10998@Kaladin>
References: <20200829175704.GA10998@Kaladin>
Subject: Re: [PATCH] clk: versatile: Add of_node_put() before return statement
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     mturquette@baylibre.com, Julia.Lawall@lip6.fr,
        linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     Sumera Priyadarsini <sylphrenadin@gmail.com>,
        linus.walleij@linaro.org
Date:   Thu, 10 Sep 2020 00:57:45 -0700
Message-ID: <159972466586.2295844.9075545722301677556@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Sumera Priyadarsini (2020-08-29 10:57:04)
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
>=20
> Fix a potential memory leak in clk-impd1.c by inserting
> of_node_put() before a return statement.
>=20
> Issue found with Coccinelle.
>=20
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> ---

Applied to clk-fixes