Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp921473pxk; Thu, 10 Sep 2020 02:06:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6Ko04+MGiRWojJiUlbqs7nQGuDfkn4WqmtJaRIIlBh8g085pwKNHqCZD6X4qdP/A3YE1O X-Received: by 2002:a05:6402:18d:: with SMTP id r13mr7893553edv.267.1599728781106; Thu, 10 Sep 2020 02:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599728781; cv=none; d=google.com; s=arc-20160816; b=R6IcizGXe6VfJyKnpxc5MnV+7IWRj2MZxrNezPBrSSumIHw1l+mUsY4l1An4jZhKq3 bIOQ6sjb1b6JlKdRv6a39yxstSFENDudixflxrXZWMPakSN0M4V4X7ilWtV7ofeifMoC AtmON7oiYSJ9X94TzkVgiZlYp7mE+ySUmM/mWoDkQuey10tEbyx+rqH3L6hiKjLL2hht MWZyGMCWEZ1viGXU2midCdbjoaDAjnVkyxFYDfmy/5jpcDG8Vw5eMGBBgud9qETHcrvu L/kS+ew640dsMVsopKRbNdsr4ANa8LC7xrWw7DcnkOKpLFus95mK+iHZRpKL2UnDYg5S XHeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=PXXK58jPCqS6xYVS0F97ACb3SCnVEU4nMHvu1m+Yjww=; b=LONck5jWd08grU5yw0bAHtCzzNOMIL0sTq+HSKU4M3DevtxUejai1H2NXGkMhBBwwz oQCriPumnLMN+1L3+EE0tQJpvAIy7l3i9fSbd17Y2URqjD/7nwTKcyhoGcIM/AduOCjV BluOez9T19i/PHGchJeL/mNGULaJLP1oiyUAdh2Fjj0zSibmbBe5VH880U5x4yJ+M074 RNxzEPyBmVQ+epJDgh88blGsGz9xpGQ33QAnRfZEWSocg3+Ro4kd0zek3XfqkbAIr4rX sffgSFnDsaWYrAjMFc9Fjir0C0cik3yp23eLc8rngNa++clgHPaYcNMFafJ9un+IsZrX jRXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="u5/cueTq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si2995331ejn.639.2020.09.10.02.05.58; Thu, 10 Sep 2020 02:06:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="u5/cueTq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726760AbgIJJDw (ORCPT + 99 others); Thu, 10 Sep 2020 05:03:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:42074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbgIJJDv (ORCPT ); Thu, 10 Sep 2020 05:03:51 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06455206A1; Thu, 10 Sep 2020 09:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599728631; bh=PXXK58jPCqS6xYVS0F97ACb3SCnVEU4nMHvu1m+Yjww=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=u5/cueTq+S2bdNS+dHMZ3rey0YBx20X/O3idxF7MPKKoBFhB4uB8oNjCldahtEx29 gXpFp9cGK6chH8HZamzspUrTZUyCWy7c6pYp8umQlTBTawp8P0wRXER6fvIUcjF3vS oc6q2KtIBUxFLCVYO6B4DrQaVY2hD8J95MCWeWVg= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200827141629.101802-1-jingxiangfeng@huawei.com> References: <20200827141629.101802-1-jingxiangfeng@huawei.com> Subject: Re: [PATCH] clk: qcom: lpass: Correct goto target in lpass_core_sc7180_probe() From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, jingxiangfeng@huawei.com To: Jing Xiangfeng , agross@kernel.org, bjorn.andersson@linaro.org, mturquette@baylibre.com, tdas@codeaurora.org Date: Thu, 10 Sep 2020 02:03:49 -0700 Message-ID: <159972862952.2295844.10882678924928944990@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jing Xiangfeng (2020-08-27 07:16:29) > lpass_core_sc7180_probe() misses to call pm_clk_destroy() and > pm_runtime_disable() in error paths. Correct goto target to fix it. > This issue is found by code inspection. >=20 > Signed-off-by: Jing Xiangfeng > --- HMm.. presumably Fixes: edab812d802d ("clk: qcom: lpass: Add support for LPASS clock control= ler for SC7180") should be added?