Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: bR6YK92waCsZSd6Ooij8Utr5tRLTxBE9sDcGD0iPyO8Ue9j2tXVpnJfiooMABL2lX+ExO01Swj
 MW0xATa/SSUg==
IronPort-SDR: QNL2ND1L1tyhKLpG+ZKs4Uxjdz2jyVmYfTfMOhFiTmMbn76ZfN/EJu0efVynxxtX+NeB2iCJOB
 qmxWV+qox5Fg==
Date:   Thu, 10 Sep 2020 12:33:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Cc:     jdelvare@suse.com, linux@roeck-us.net, p.zabel@pengutronix.de,
        linux-hwmon@vger.kernel.org, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        songjun.Wu@intel.com, cheol.yong.kim@intel.com,
        qi-ming.wu@intel.com, rtanwar@maxlinear.com
Subject: Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller
Message-ID: <20200910093353.GN1891694@smile.fi.intel.com>
References: <cover.1599634208.git.rahul.tanwar@linux.intel.com>
 <ecb6794a8f2ef6576421e6d5fbdf4e6a91f06b91.1599634208.git.rahul.tanwar@linux.intel.com>
 <20200909103317.GL1891694@smile.fi.intel.com>
 <41cf7b4d-2476-4d0e-0dae-f0200649d7dd@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <41cf7b4d-2476-4d0e-0dae-f0200649d7dd@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 10, 2020 at 03:26:04PM +0800, Tanwar, Rahul wrote:
> On 9/9/2020 6:33 pm, Andy Shevchenko wrote:
> > On Wed, Sep 09, 2020 at 02:52:05PM +0800, Rahul Tanwar wrote:

...

> >> +#include <linux/of.h>
> > I don't see anything special about OF here.
> > Perhaps
> > 	mod_devicetable.h
> > 	property.h
> > ?
> 
> of.h is needed because of of_property_read_u8_array(). I will add
> mod_devicetable.h.
> property.h seems not required at all.

if you use device property API then it will be more generic.

...

> >> +static struct regmap_config pvt_regmap_config = {
> >> +	.reg_bits = 32,
> >> +	.reg_stride = 4,
> >> +	.val_bits = 32,
> > How do you use regmap's lock?
> 
> We mutex lock whenever read temperature or voltage values from the registers.
> All non-probe/non-init paths. We do not override regmap's internal lock.

Exactly and my point is why do we have too many locks?

> >> +};

-- 
With Best Regards,
Andy Shevchenko