Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: RSFpXgk9nZww271BvcZdqf6JzrEkhi+O5Ko2odDr/hsTxWMliyZblIykJogBk82WmgrxTRoZ2L
 EobltJLnNAPw==
IronPort-SDR: XJWYxuPu2GWVcdPC1X7jIACq/yOg+98XSsMf6itNFjMakvjQbmI6JPAEK9khdqPzls+soUVDIq
 uVnblaCZrVLg==
Date:   Thu, 10 Sep 2020 12:46:22 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Cc:     Guenter Roeck <linux@roeck-us.net>, jdelvare@suse.com,
        p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org,
        robh+dt@kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, songjun.Wu@intel.com,
        cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
        rtanwar@maxlinear.com
Subject: Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller
Message-ID: <20200910094622.GO1891694@smile.fi.intel.com>
References: <cover.1599634208.git.rahul.tanwar@linux.intel.com>
 <ecb6794a8f2ef6576421e6d5fbdf4e6a91f06b91.1599634208.git.rahul.tanwar@linux.intel.com>
 <a3b95ea8-372b-4f03-0c04-62ee9384fafb@roeck-us.net>
 <c72665ba-b594-bbb0-00c5-ed763233d609@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c72665ba-b594-bbb0-00c5-ed763233d609@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 10, 2020 at 03:27:11PM +0800, Tanwar, Rahul wrote:
> On 9/9/2020 11:05 pm, Guenter Roeck wrote:
> > On 9/8/20 11:52 PM, Rahul Tanwar wrote:

...

> >> +static int pvt_get_regmap(struct platform_device *pdev, char *reg_name)
> >> +{
> >> +	struct device *dev = &pdev->dev;
> >> +	struct pvt_device *pvt = platform_get_drvdata(pdev);
> > I am quite at loss how this is supposed to work. Platform driver
> > data is not initialized with a pointer to struct pvt_device at this point.
> > How does this code not crash ? What am I missing ?
> 
> Big mistake on my part. Last minute change based on internal review feedback
> about moving platform_set_drvdata() at the end of probe. I will fix it in v2.
> Thanks.

Since IIRC it was me who suggested this I should say that reviewer can make
mistakes, on the other hand contributor should have had known their code to
refuse certain changes.

-- 
With Best Regards,
Andy Shevchenko