Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1101205pxk; Thu, 10 Sep 2020 07:09:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8EWB5syEgH/XYw8ouzf2o7FWv2Z3skRLYc8hlM0Lk+ahTbLvE7nOOiJbCRg0FSg24b6xd X-Received: by 2002:aa7:d4d2:: with SMTP id t18mr9313838edr.55.1599746946452; Thu, 10 Sep 2020 07:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599746946; cv=none; d=google.com; s=arc-20160816; b=zVDcC07mFiuDuk9xZr0odOy3MWCGWVjvJIULKiAEuDRY4ksIJ7lYuS4tuZa84cfTTH SpGlyw+78uWjDvmeiUIqH50htCfhdwTb3MeDrX2HQqqNsoJ1ivLr225ksBgWR/yTfrl9 eVxc3M0IXvEbMvXM045ciYnuzOH0mccFxlZ4okEyQmIiKz0k1jyDWScPjWVQibZWsa9z z/oNrf6xhBUZQOO+9N4o+7TqxE1ZGL7d/xDz0crj8zbvrGcL32p/Z1WggRHYq7LX70x3 /IvujUUfy/agGFtNpe9gAox1mkSgTpNKJlEyUQkTNP0YRALHDMr26tRVSeQ7ZJ3whhJh FVzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=JfdFti8xkV0Uu7Q2T+YcBJwhn96i//hmbBhTEew1zi4=; b=gkUopWwAk3k4P2wA5rVv6hb6hLDBQCFCOl9O13k7ZnDdGGXXQ1o/giiY862kLbuGi0 qf1PoiVVAxmmrhXBcCQLrAUELW+xnTZ0beJf6XOd1K7HUh2rh22hCxCm9+2kHNniBTQZ 6TYHXCAzMT9rEtzOVfXpVD5SOw/VULBpyyqKKtN5J/2UGKWNkHqHc4VpsBGQY/w0AKS8 aRH5cUP+VTzAAsBSO0qxhIzmPvy9mfxdfpdW9SoXZBWE0o+e6jycLGlo6iYXDY27vOZ2 /oy66HrOZOQU5oq4grYelv2JrE16MNBiPO9R6YeUMQzEW+unGJnkS9gySEMwWo05pG6s Fb5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp9si3820169ejc.203.2020.09.10.07.08.43; Thu, 10 Sep 2020 07:09:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731013AbgIJOCN (ORCPT + 99 others); Thu, 10 Sep 2020 10:02:13 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:11776 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730992AbgIJNyu (ORCPT ); Thu, 10 Sep 2020 09:54:50 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E32177AABAC7776F98AE; Thu, 10 Sep 2020 21:52:30 +0800 (CST) Received: from huawei.com (10.90.53.225) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Thu, 10 Sep 2020 21:52:23 +0800 From: Zheng Bin To: , , , , , , CC: , Subject: [PATCH -next 3/3] rtlwifi: rtl8188ee: fix comparison pointer to bool warning in hw.c Date: Thu, 10 Sep 2020 21:59:17 +0800 Message-ID: <20200910135917.143723-4-zhengbin13@huawei.com> X-Mailer: git-send-email 2.26.0.106.g9fadedd In-Reply-To: <20200910135917.143723-1-zhengbin13@huawei.com> References: <20200910135917.143723-1-zhengbin13@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.225] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:777:14-20: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:782:13-19: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:787:14-20: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:792:13-19: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:871:6-33: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:1070:5-13: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c index 4c8d71fbdd7a..63f9ea21962f 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c @@ -774,22 +774,22 @@ static bool _rtl88ee_llt_table_init(struct ieee80211_hw *hw) for (i = 0; i < (txpktbuf_bndy - 1); i++) { status = _rtl88ee_llt_write(hw, i, i + 1); - if (true != status) + if (!status) return status; } status = _rtl88ee_llt_write(hw, (txpktbuf_bndy - 1), 0xFF); - if (true != status) + if (!status) return status; for (i = txpktbuf_bndy; i < maxpage; i++) { status = _rtl88ee_llt_write(hw, i, (i + 1)); - if (true != status) + if (!status) return status; } status = _rtl88ee_llt_write(hw, maxpage, txpktbuf_bndy); - if (true != status) + if (!status) return status; return true; @@ -868,7 +868,7 @@ static bool _rtl88ee_init_mac(struct ieee80211_hw *hw) rtl_write_byte(rtlpriv, MSR, 0x00); if (!rtlhal->mac_func_enable) { - if (_rtl88ee_llt_table_init(hw) == false) { + if (!_rtl88ee_llt_table_init(hw)) { rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD, "LLT table init fail\n"); return false; @@ -1067,7 +1067,7 @@ int rtl88ee_hw_init(struct ieee80211_hw *hw) } rtstatus = _rtl88ee_init_mac(hw); - if (rtstatus != true) { + if (!rtstatus) { pr_info("Init MAC failed\n"); err = 1; goto exit; -- 2.26.0.106.g9fadedd