Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1197975pxk; Thu, 10 Sep 2020 09:18:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrRuAuqX8P4mIVrggwdL9DXdSw/xbHuXsuiRn3Uo9Sj7j2LEtUoGk3HblTnDZkWubM/t3g X-Received: by 2002:a17:906:f6c6:: with SMTP id jo6mr9431429ejb.251.1599754680641; Thu, 10 Sep 2020 09:18:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599754680; cv=none; d=google.com; s=arc-20160816; b=X4MF/LR1UHVKftVRG10MQNReiuwAPGJIwbffoh4mVamDH0pj2S5VG7TIDEYo7ds1mv 8jow6mYL8QvLTEabT+QwkedxjCrDJpV/DHrCljwWZEKLuGxebcJ69p16fTUMAVzuv+sF UwdqN65BlEeuFa/EoMxnVnZRikEM/c/Y7sZr24BZll0sQnKfCgtmR8P8sNUCD/fB1cfG QTBAUe9soMs64cksAvYwJ6R4qV/Bd2z3tqCz+jLzLfln5G0oQjEXvxOhVR5bKXCNDymA s2+2F5xSOqwGBr5N5mYc7ks5+QCl/8OhQhccFdNd8hWUdTH61Vpwlz8Tc5IYShftucR9 160Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature:dkim-signature; bh=fI8DEsSj+LPMaCnZXcDQcnQTO37fM6MsNrmcAqPBisI=; b=aoCE7DWgunFI+pi6FfZdoyQLcjXg3m7dZAFnoiUpFERpMAZt4rk3Ir8ZXUVSLlV6eW 43kG6MVxot/mLP2zX//eBJmJm7UbVJTCKQYRF73MsuVteSTZlbUx9GRK8pVafkO0i4N2 PzgjY/HBMT4mtbaviFuVX+k5fgxAWBQxhpM3Ljj6LbLMo3xNF7WUGuRsShyhKkY5j84Q fgwbVvEmnlA+f9/7nlmS5i7tRTbvWCqWq0IxUyrADvuAiocpBCZxd7IeIO3x+zeFRZeK sCCMaTDkOGpTnm2FMHXT2kUtkaQ93V1D0akMYWLruWmxOkwsZvSwm7rPqeBMD13UCBiO D7sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=SqTOBGdd; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=SqTOBGdd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si3801005ejd.140.2020.09.10.09.17.36; Thu, 10 Sep 2020 09:18:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=SqTOBGdd; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=SqTOBGdd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbgIJQLx (ORCPT + 99 others); Thu, 10 Sep 2020 12:11:53 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:54580 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgIJQJo (ORCPT ); Thu, 10 Sep 2020 12:09:44 -0400 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id B4B848EE11E; Thu, 10 Sep 2020 09:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1599754150; bh=vjqoZjjs4ZL988BGG7sXtVJHzIb1zQDOeZ88/1JThQw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SqTOBGdd05DEXZCUAUSRCFQLQh+D8HlmsHDZknIpCoLNKWMiASjKLlkwGQpE1qB2y Ra66T5QAZClQDQ1tI6wCPqz6A+A1azS+MUvPfnrYOwq0bWYX6ZlSPFX3WbX9nPfwsv HXiNLeDe7+r88pNXMcY6eguRdu3R4RQu703OyKHk= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c7vL7lTQ-z-f; Thu, 10 Sep 2020 09:09:10 -0700 (PDT) Received: from [153.66.254.174] (c-73-35-198-56.hsd1.wa.comcast.net [73.35.198.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 6C6ED8EE0E2; Thu, 10 Sep 2020 09:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1599754150; bh=vjqoZjjs4ZL988BGG7sXtVJHzIb1zQDOeZ88/1JThQw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SqTOBGdd05DEXZCUAUSRCFQLQh+D8HlmsHDZknIpCoLNKWMiASjKLlkwGQpE1qB2y Ra66T5QAZClQDQ1tI6wCPqz6A+A1azS+MUvPfnrYOwq0bWYX6ZlSPFX3WbX9nPfwsv HXiNLeDe7+r88pNXMcY6eguRdu3R4RQu703OyKHk= Message-ID: <1599754148.3575.4.camel@HansenPartnership.com> Subject: Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell From: James Bottomley To: Stanley Chu Cc: "Martin K. Petersen" , Can Guo , asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, ziqichen@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , Avri Altman , Matthias Brugger , Bean Huo , Bart Van Assche , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Date: Thu, 10 Sep 2020 09:09:08 -0700 In-Reply-To: <1599725880.10649.35.camel@mtkswgap22> References: <1599099873-32579-1-git-send-email-cang@codeaurora.org> <1599099873-32579-2-git-send-email-cang@codeaurora.org> <1599627906.10803.65.camel@linux.ibm.com> <1599706080.10649.30.camel@mtkswgap22> <1599718697.3851.3.camel@HansenPartnership.com> <1599725880.10649.35.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-09-10 at 16:18 +0800, Stanley Chu wrote: [...] > > + if (!err) { > > +cleanup: > > Yeah, considering Bean Huo's patch "scsi: ufs: No need to send Abort > Task if the task in DB was cleared", "cleanup" label shall be added > back here. > > So your resolution looks good to me. > > Thanks so much : ) You're welcome ... but just remember I have to explain this to Linus when the merge window opens. It would be a lot easier if this hadn't happened so please don't make it any worse ... James