Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: KOhw8S+7kFEnJhg+e08zHLLGmUJKY/uV5kZAv0hM38EpJm3ZlIw1l8g0azSZEYkSdExnwC3ac0
 0MGkkMj/dA9A==
IronPort-SDR: pAEPlXHx0J9Ojxd2huzRur81oXMV+9rzxu43DswPATT3urzvIZ3iemK3xawRX6VHfv6Yq8MBxG
 Lk6uo1p1/1cA==
From:   "Eads, Gage" <gage.eads@intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "Karlsson, Magnus" <magnus.karlsson@intel.com>,
        "Topel, Bjorn" <bjorn.topel@intel.com>
Subject: RE: [PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver
Thread-Topic: [PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver
Thread-Index: AQHWhRcMCBS5jrzbZkavfoY9EXJ14aliEEMQgAAFaACAAAClMA==
Date:   Thu, 10 Sep 2020 16:52:37 +0000
Message-ID: <SN6PR11MB257475DF5F45FED24F4D4968F6270@SN6PR11MB2574.namprd11.prod.outlook.com>
References: <20200901191548.31646-1-gage.eads@intel.com>
 <20200901191548.31646-2-gage.eads@intel.com>
 <20200907130150.GE2371705@kroah.com>
 <SN6PR11MB2574DA2AA215E9566BA4F410F6270@SN6PR11MB2574.namprd11.prod.outlook.com>
 <20200910163208.GA1321670@kroah.com>
In-Reply-To: <20200910163208.GA1321670@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ecb89772-f0a1-4b4b-aec4-08d855a9eca5
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2020 16:52:37.9831
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Deqq4aNpmQA1S14Ct6hSby624oFKgM7eY3vA779b2OYKNczzu5QpNUMfqLDFSZ4sszxFgFSgqjhQudeIo5yKeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3104
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, September 10, 2020 11:32 AM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> Subject: Re: [PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver
>=20
> On Thu, Sep 10, 2020 at 04:24:31PM +0000, Eads, Gage wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh@linuxfoundation.org>
> > > Sent: Monday, September 7, 2020 8:02 AM
> > > To: Eads, Gage <gage.eads@intel.com>
> > > Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> > > <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> > > Subject: Re: [PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver
> > >
> > > On Tue, Sep 01, 2020 at 02:15:30PM -0500, Gage Eads wrote:
> > > > --- /dev/null
> > > > +++ b/drivers/misc/dlb2/dlb2_main.c
> > > > @@ -0,0 +1,208 @@
> > > > +// SPDX-License-Identifier: GPL-2.0-only
> > > > +/* Copyright(c) 2018-2020 Intel Corporation */
> > > > +
> > > > +#include <linux/aer.h>
> > > > +#include <linux/cdev.h>
> > > > +#include <linux/delay.h>
> > > > +#include <linux/fs.h>
> > > > +#include <linux/init.h>
> > > > +#include <linux/list.h>
> > > > +#include <linux/module.h>
> > > > +#include <linux/pci.h>
> > > > +#include <linux/uaccess.h>
> > > > +
> > > > +#include "dlb2_main.h"
> > > > +
> > > > +static const char
> > > > +dlb2_driver_copyright[] =3D "Copyright(c) 2018-2020 Intel Corporat=
ion";
> > >
> > > Why have this in a string and then:
> > >
> > > > +MODULE_LICENSE("GPL v2");
> > > > +MODULE_AUTHOR("Copyright(c) 2018-2020 Intel Corporation");
> > >
> > > Not use it?
> > >
> > > It's probably not needed at all, right?
> > >
> > > Don't you get a build warning about this when applying and building t=
his
> > > patch?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > dlb2_driver_copyright was used in a pr_info() in the v1 patchset that w=
as
> > removed at Arnd's recommendation, and I forgot to remove the string.
> Will fix.
> > The unused warning variable was likely missed in the deluge of warnings
> from
> > included kernel headers.
>=20
> You should not have any build warnings.  If you do, then something is
> really wrong, the kernel builds cleanly today.
>=20
> thanks,
>=20
> greg k-h

Sorry, I worded that ambiguously. The driver builds without any warnings wi=
th
my GCC (7.3.1) by default. The deluge from kernel headers only occurs after
adding EXTRA_CFLAGS=3D-W. There shouldn't be any dlb2 warnings with -W enab=
led,
but I'll double check.

Thanks,
Gage