Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1270586pxk; Thu, 10 Sep 2020 11:08:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFstJ/vodLpV7VmR4KaHn0EJVTT/Gb2zsDVG4woZ4/cglJlJDnik/fF6dhFMEbKTrXXPYE X-Received: by 2002:a17:906:2962:: with SMTP id x2mr9930547ejd.188.1599761289808; Thu, 10 Sep 2020 11:08:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599761289; cv=none; d=google.com; s=arc-20160816; b=Zo7nNLIjNy52UfPg8cBYq42a2KYGYMiZf6jgmqli2plew81NzWGb6VP0beuXBaE5Fn NYiA+op+RbuTmwunjVhcRnO/lZkvlJTONg4dP+pdDy1BUSMbuNH5ZHcVy4Nk4vsym/8c CjbnYmfhzXg+y0CICMlE1r769ocis+q09tAvTcuNDFWrhIYtuwoLLxo/+UyPe9nXdeIg AYnethA3bjWEUNQdxXOZtWPUq3oPu1G93FWcWy0sjso9/oTHTw+scMWtKPw1Sc7xcs03 2R6hLXEdhGeIsm662bCiVfQQgZ8sbxp/hTK8ioS594+hwadSNIFlYdJx5h8b7iUrocXo bRTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=KVk+qptF8oO5IEsK8Vxli31iK/EU6lwYb0wq/Z1gS1I=; b=ni2Lr16cRbV9BQyqvw+Db5/0LjtFZq1qYQdqDY1CK3TO5OSI76zsfoC0H5XWWz9RTg ajydxP18OcfaoUNdD0tOD65jMzfmZr6mEUB4hnVf9hb1AAhqDNZxjZNMPUqa94ELoV/p sAiNbAuwpJ0Dw0Bpw9Qinnhe54k37ZHq2kGrzO2ZiPpDEl9kBIDLyQ07b+Rdza7oSKvX SgGD9BbgHxEX104l2Nfgc1+jieXGoncalBz8UQmNAwOwjc1+KG2XFx7SXFxpi7JGIctS ExBmJ7DCmouZQGZUAyM68nD5KF5pOK0NizTH9+kn0MnRmd8a+9z369stat/UUfO+MA0q SvEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u18si4199792edy.380.2020.09.10.11.07.45; Thu, 10 Sep 2020 11:08:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725866AbgIJSHE (ORCPT + 99 others); Thu, 10 Sep 2020 14:07:04 -0400 Received: from mga03.intel.com ([134.134.136.65]:8888 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726781AbgIJSGd (ORCPT ); Thu, 10 Sep 2020 14:06:33 -0400 IronPort-SDR: ihsw14IEDztMFrsbGpSMqaAo10izxb84dtuwYqaYXw50kbAvP7ek/oBZ5pCOzNQNvvojWdOxMY MY20tK7KAKAw== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="158643332" X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="158643332" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 11:06:13 -0700 IronPort-SDR: TbgBTxIPfPO2q3x6WUpY71mIX7SVfd8A37B2i0+LloyCOO9FB+mrsi21XpYbGQaGB26TwRPORs yr/lw+0Tr2KQ== X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="505920334" Received: from rdraharj-mobl1.amr.corp.intel.com (HELO [10.209.137.6]) ([10.209.137.6]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 11:06:11 -0700 Subject: Re: [PATCH V6] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine To: Radoslaw Biernacki , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Cc: Lech Betlej , alsa-devel@alsa-project.org, Todd Broch , Harshapriya , John Hsu , linux-kernel@vger.kernel.org, michal.sienkiewicz@intel.com, Ben Zhang , Mac Chiang , Yong Zhi , Marcin Wojtas , Vamshi Krishna , Alex Levin References: <20200910172538.31425-1-rad@semihalf.com> From: Pierre-Louis Bossart Message-ID: Date: Thu, 10 Sep 2020 13:06:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200910172538.31425-1-rad@semihalf.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/10/20 12:25 PM, Radoslaw Biernacki wrote: > Since 256xFS clocks cannot be generated by SKL, the NAU8825 is > configured to re-generate its system clock from the BCLK using the > FLL. The link is configured to use a 48kHz frame rate, and 24 bits in > 25-bit slot. The SSP configuration is extracted from NHLT settings and > not dynamically changed. Listening tests and measurements do not show > any distortion or issues > > Signed-off-by: John Hsu > Signed-off-by: Yong Zhi > Signed-off-by: Mac Chiang > Signed-off-by: Ben Zhang > Signed-off-by: Radoslaw Biernacki > --- LGTM, thanks! Reviewed-by: Pierre-Louis Bossart