Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fc4effe1bbe6e9c68f4bdd863e3d38cbab52a285.camel@kernel.org>
Subject: Re: [PATCH 4.19] net/mlx5e: Don't support phys switch id if not in
 switchdev mode
From:   Saeed Mahameed <saeed@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Saeed Mahameed <saeedm@mellanox.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        netdev@vger.kernel.org, Roi Dayan <roid@mellanox.com>
Date:   Thu, 10 Sep 2020 11:46:36 -0700
In-Reply-To: <20200807131323.GA664450@kroah.com>
References: <20200807020542.636290-1-saeedm@mellanox.com>
         <20200807131323.GA664450@kroah.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2020-08-07 at 15:13 +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 06, 2020 at 07:05:42PM -0700, Saeed Mahameed wrote:
> > From: Roi Dayan <roid@mellanox.com>
> > 
> > Support for phys switch id ndo added for representors and if
> > we do not have representors there is no need to support it.
> > Since each port return different switch id supporting this
> > block support for creating bond over PFs and attaching to bridge
> > in legacy mode.
> > 
> > This bug doesn't exist upstream as the code got refactored and the
> > netdev api is totally different.
> > 
> > Fixes: cb67b832921c ("net/mlx5e: Introduce SRIOV VF representors")
> > Signed-off-by: Roi Dayan <roid@mellanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> > ---
> > Hi Greg,
> > 
> > Sorry for submitting a non upstream patch, but this bug is
> > bothering some users on 4.19-stable kernels and it doesn't exist
> > upstream, so i hope you are ok with backporting this one liner
> > patch.
> 
> Also queued up to 4.9.y and 4.14.y.
> 

Hi Greg, the request was originally made for 4.19.y kernel,
I see the patch in 4.9 and 4.14 but not in 4.19 can we push it to 4.19
as well ? 

Thanks,
Saeed.