Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Sep 2020 21:13:47 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Lubomir Rintel <lkundrak@v3.sk>,
        Mark Brown <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Josua Mayer <josua.mayer@jm0.eu>,
        Andreas Kemnade <andreas@kemnade.info>,
        Arnd Bergmann <arnd@arndb.de>, Daniel Palmer <daniel@0x0f.com>
Subject: Re: [PATCH v2 05/10] pwm: ntxec: Add driver for PWM function in
 Netronix EC
Message-ID: <20200910191347.GC3306@latitude>
References: <20200905133230.1014581-1-j.neuschaefer@gmx.net>
 <20200905133230.1014581-6-j.neuschaefer@gmx.net>
 <CAHp75VdUHoOyM3bObzhdfiqpne0AmSK_UakteTZxnjqJVrNV9A@mail.gmail.com>
 <20200908081445.GC4400@dell>
 <CAHp75Veb5nVasy28FSksf06eVVhC8N5hHsEPM-2YcFbMjZ5Rhw@mail.gmail.com>
 <20200908093538.GM4400@dell>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="+xNpyl7Qekk2NvDX"
Content-Disposition: inline
In-Reply-To: <20200908093538.GM4400@dell>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--+xNpyl7Qekk2NvDX
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 08, 2020 at 10:35:38AM +0100, Lee Jones wrote:
> On Tue, 08 Sep 2020, Andy Shevchenko wrote:
>=20
> > On Tue, Sep 8, 2020 at 11:14 AM Lee Jones <lee.jones@linaro.org> wrote:
> > > On Sat, 05 Sep 2020, Andy Shevchenko wrote:
> > > > On Saturday, September 5, 2020, Jonathan Neusch=C3=A4fer <j.neuscha=
efer@gmx.net>
[...]
> > > > > +       depends on MFD_NTXEC && OF
> > > >
> > > >
> > > > I don=E2=80=99t see need to reduce test coverage and use of the dri=
ver by sticking
> > > > with OF. Actually it=E2=80=99s not used.
> > >
> > > If the device is only known to boot with OF, then it's pointless
> > > building it when !OF.
> >=20
> > No, it's not. As I pointed out the (compilation) test coverage is bette=
r.
>=20
> No, it's a waste of disk space.
>=20
> Why would you knowingly compile something you know you can't use?
>=20
> That's the whole point of COMPILE_TEST.
>=20
> Note that when you want real coverage and you use `allyesconfig`
> and/or `allmodconfig` then CONFIG_OF is also enabled on platforms
> which support it.
>=20
> > > If you want to increase test coverage enable
> > > COMPILE_TEST instead.
> >=20
> > It is one way to achieve that, yes;
> >=20
> >        depends on OF || COMPILE_TEST
> >        depends on MFD_NTXEC
>=20
> This is better.

Ok, I'll go with this variant.


Thanks

--+xNpyl7Qekk2NvDX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl9aeuoACgkQCDBEmo7z
X9vkeQ//Z6VkR7LUMRr15RrcOim2rTLOTurj8YLz+0euJs2UiKbWB1g1sq0EUbl4
oF0lpeQ7r32jaBtYOaMbJnl+seUEeBb8UQGXtS0QTdpOiQO2l0aRWJUpGOWmFjoy
sNPF0FJOKsJ7hE0hgHrplJcVUMaWI6RcICTpEFWXaXBjsOi0JyWVYXPmHcSXewDm
OBWmV+AHu6xnVAnsf/d38DJSGMGGlmTqyfwy5f1Hex0k84lC8/UnZZncG0eSqEEj
nnTb8qWCsmAuyA9VXniUsdw8czkVLXHH9Nb2gZkxC4rACWHGdx5zJQgOMl57GR3Z
P4Be4YaCVUGrRSyxzwdZAESOR/SXyX807Vienx2oPud1EVW0WanG0E0oo51MmItm
sy3ztPgb3KWEcB03EwNKNIyECn41sxkQYnj2hvZMDdjIwcX+zBerlkMib5FIHygk
IvDE46MfLDxkbcWL1Rf+YsTUYfkGfg5LRaEjlIfhW+xErcW2WDjCoA9DfnZLMJUS
tFqIYmUous2y2g8JYXUYlFLD1OhaKSjbmDFGbSzQWURynxz6pSejboqIb+FM7TNA
f6hmHZH+O7d0uOGCzsbKszzz4haHdSzxnuMhV3ZsSxB4r/bKCBWlyGsdBqcx9eDw
AKWxNJZlp5Mj7j5Gow94BY9+8UZMjGk+mSUh/aCHok6Ll5+Zdx4=
=lXFL
-----END PGP SIGNATURE-----

--+xNpyl7Qekk2NvDX--