Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1341106pxk; Thu, 10 Sep 2020 13:00:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVgG0p4xZadm4D3AWznVRbl5ScVJReeJ2Nb8h2Ew+b1gI6GEUUUydynCP0oVFgK3m1e4o3 X-Received: by 2002:a05:6402:17b6:: with SMTP id j22mr10585066edy.377.1599768005022; Thu, 10 Sep 2020 13:00:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599768005; cv=none; d=google.com; s=arc-20160816; b=yI4/Ly67BJvIuaGG2yXkUuEmHKsccemyr29cSXig3R31cfHU6iWOBBUF/D6bZ9qBSV 6KVwMaYNMuFx5XAfj2wIY8nrDfYHBNXdxH1rsM3rj7JZsLa8dfkps0MZ2EPiBtBPP1fs Yz4WhaMNPajk6SmDgR9l19b3+S9Fy+Ls19UHNBX31rAuciloLrHZwhczadECRsk/J2kr BEK/EgCkJWH8jzmmMnKB9QcDCCyEWQdJV/oRtnPHMSaltrmbrMX3X8c9Ssu4HtmKTn3n U6P103lEZcfaTcj2UmQ9aJ66P8HSiHJhf6aXWUHZlOpwTACb7e7oaE4K91NOOnOTqw3u CYDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=utzD7oi90/kRcS7CaXYQXkECrA3AuD5w0CxC4ohp38c=; b=AMaFZNlFqhdPfDTn1oWf+NGUrmrUgtG240GqShCtdmooVwKkRUvRFkD/M3aRtjavzG daczh4ap0X+CfZvcza7F5q1AKN2HI0E4ikn3kWyd7dwcEBp77HcKovCnUj21Zcft9YWd t4NzN+mLlmpxSIk2iB0peG4gD1IekmpjkF5VaglwXo4DX8LhZIEhqnnJxpALSmEiEGkA 8sJ5k1iGwyPiXYsy1IV0OVVYxfwc1ToWSXpvSMeMsicVdqnJ3lbdR7ghsjInYG9gx1LX bpjTmMLkpcot5NpE/vvu7kiNETpkqzacf/vrNhZz3KuQYVI+q4W0GIMBuP6ZEz28FoW8 ndIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k25si4739701ejk.235.2020.09.10.12.59.42; Thu, 10 Sep 2020 13:00:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbgIJT5B (ORCPT + 99 others); Thu, 10 Sep 2020 15:57:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbgIJTz7 (ORCPT ); Thu, 10 Sep 2020 15:55:59 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 065EAC061756; Thu, 10 Sep 2020 12:55:56 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0853612A34059; Thu, 10 Sep 2020 12:39:08 -0700 (PDT) Date: Thu, 10 Sep 2020 12:55:53 -0700 (PDT) Message-Id: <20200910.125553.598018287826728299.davem@davemloft.net> To: decui@microsoft.com Cc: kuba@kernel.org, wei.liu@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mikelley@microsoft.com, saeedm@mellanox.com, markb@mellanox.com Subject: Re: [PATCH net 1/2] hv_netvsc: Switch the data path at the right time during hibernation From: David Miller In-Reply-To: <20200909040732.18993-1-decui@microsoft.com> References: <20200909040732.18993-1-decui@microsoft.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Thu, 10 Sep 2020 12:39:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dexuan Cui Date: Tue, 8 Sep 2020 21:07:32 -0700 > When netvsc_resume() is called, the mlx5 VF NIC has not been resumed yet, > so in the future the host might sliently fail the call netvsc_vf_changed() > -> netvsc_switch_datapath() there, even if the call works now. > > Call netvsc_vf_changed() in the NETDEV_CHANGE event handler: at that time > the mlx5 VF NIC has been resumed. > > Fixes: 19162fd4063a ("hv_netvsc: Fix hibernation for mlx5 VF driver") > Signed-off-by: Dexuan Cui Applied.