Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1372821pxk; Thu, 10 Sep 2020 13:45:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxycZ134cVKVoaGn8kHZIp23Z2ARv4jMyqiVpR0gNnV7KngqoTPldlpT4JLPjKSYE9dRNtg X-Received: by 2002:a05:6402:1b9a:: with SMTP id cc26mr11083631edb.30.1599770735969; Thu, 10 Sep 2020 13:45:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599770735; cv=none; d=google.com; s=arc-20160816; b=lpFbbLxEPQ0X4f3AOS9rV+8+/10oMYeitOB49FprXgbsLqnW3XdwPMTpBucQ2TRksE ZsHiGVtCCQPyUp/O77P0ATZS2zFd20GYDoNO4ygliPbmvSGVyW4WthKhvex0L71I5oYJ mGGByl/+1Qal2A63oG5PI25BN7AuAbx2E7JIbb9um6ziniP6RBrydzDnvSqEfvwknnNH TO4YOqSetepA4c/GD+i22Wp5xEA6+CgdAKkS79Z3uilx+/kiGNdhnkeOWo1EhZG6Wgvk FybtUY9wiod1NEriYnjTSZ7WGMEKjHef2Ov9KD75QTawpe52sVaJ5QZnWcydqVUPwcNC 0nWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=j+p+Inr+01436rceX6HgIBOmz1/CWOcyjjR8EinR1do=; b=Dr3w0f34zrcKrluEkO1p756RTkwqminRN69nW8H77bEa7vPwcSKwfdYDaf+ATPb+qE iPjh4WhD0yHZQSohqmHrCFpi57RAKm7nScMfeIguJ5meCxkGdMjeJMMeyMwah2MjzfhV v5Xldg9J7uBS1naBK/XP7zrTjvbg1m1+VmQ29Z3/SwKpcOkNw5ScSqA+Z7uNyC6gCPKO D951CaQckl5245J3va0xHTz9AB0cvWKoXN/4deE4QADQ/pVgziFte33m9E7K0wEbZZNq L59SqMkLuQrwWhXn+ijxf8ip0tyktb6KHJwsuMcFfZzLtd/go+JfNmcFFUv0qCITHdq6 vEgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=P6YCTEGx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si4461915edp.364.2020.09.10.13.45.12; Thu, 10 Sep 2020 13:45:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=P6YCTEGx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727030AbgIJUoB (ORCPT + 99 others); Thu, 10 Sep 2020 16:44:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:35984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726996AbgIJUnn (ORCPT ); Thu, 10 Sep 2020 16:43:43 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B63520829; Thu, 10 Sep 2020 20:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599770621; bh=j+p+Inr+01436rceX6HgIBOmz1/CWOcyjjR8EinR1do=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=P6YCTEGxTcaZP5txtO2xc3RkgLSV1D/91twidLjbvrsAcHLzP4Xco94zzyBeQxFAO f6x+2dYA7bUxehdbkzD5QF1wwD8+4AnxUo7StqDdbJHXu8l9y7sRBUckYFoRxSkgI6 SdDk//PFpVAOmT6hQiFZv0jGjNkigaz2FMY5UNxM= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200827141629.101802-1-jingxiangfeng@huawei.com> References: <20200827141629.101802-1-jingxiangfeng@huawei.com> Subject: Re: [PATCH] clk: qcom: lpass: Correct goto target in lpass_core_sc7180_probe() From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, jingxiangfeng@huawei.com To: Jing Xiangfeng , agross@kernel.org, bjorn.andersson@linaro.org, mturquette@baylibre.com, tdas@codeaurora.org Date: Thu, 10 Sep 2020 13:43:39 -0700 Message-ID: <159977061963.2295844.8449018539561172651@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jing Xiangfeng (2020-08-27 07:16:29) > lpass_core_sc7180_probe() misses to call pm_clk_destroy() and > pm_runtime_disable() in error paths. Correct goto target to fix it. > This issue is found by code inspection. >=20 > Signed-off-by: Jing Xiangfeng > --- Applied to clk-fixes