Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1400055pxk; Thu, 10 Sep 2020 14:28:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyHvrAmfSqpYjIIWVgCtZ3EZmaI2bzXNT85KbW4fA+2cS9/PM37Nbda1xNc4D4dfwqInJr X-Received: by 2002:a17:907:7293:: with SMTP id dt19mr10722529ejc.5.1599773308350; Thu, 10 Sep 2020 14:28:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599773308; cv=none; d=google.com; s=arc-20160816; b=rZb437qSWHCuPD4duEjSsk/PHpkaFXdGwbkxwuM2pfRkU+8AHvM0K9zzre4kGQxyic kxBuQXxxd7sRmqbTnU+4FzXSOGzQh/LpQTDYIYo7rb62ohm1H8jzNhpd17UYKP+qGbE0 Jc1hnC/l4DQuG0knfeC703TR6ooPDDDOk1fE637/y9b13t/OB72c6Lcwmx0hzCeae0tE xWwsNEwM6sqlH4mEjsnVhD6gg1pzn48urSyygtc1fyFj7D6fuAhWAyEJ61LxLjhESIUZ mBfcEL9HbIBDx1UbasRhUYx8SqXO0T19fYorUUEclrSd/Sxai0QNeaJwUMmWd3KNZztl R2rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=d01HhDelA1d6CT6VoI3fUj7MUajFX2LB+/fyEzpqQ1c=; b=FWqHz/5Gmfj7HbBoArD6wcnSLtwtcycykkc0RHzfmQrwxByMP0ZgscJRiLmHXua+jQ MZe23HisEZNoMtd9NxWrI5A9RA+RMSzmVARrIOHLqraO+MEEDzSrbI/XnSOLP+9vn6OC RBjDQruUkYV/62szqbjqZmBpGlsvSV5thmmt8+QFAf99pQpzrNzy/9zMyLcsL/NzRvKu ykuGri2bSCujQxSGcMU15mDy5aLEeuLhCFw66YVScOUjkPOgfNRYzxNSw6/t2IaJhzDu Pat8VXuVzC4sS7ii+0m6n4hDOmKFOqk/NcBxNBhZwmpqCFATVnFB/YcXpzDoQ/WXGHHC o9Iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si4495489ejm.344.2020.09.10.14.28.06; Thu, 10 Sep 2020 14:28:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726853AbgIJVZi (ORCPT + 99 others); Thu, 10 Sep 2020 17:25:38 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:11795 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730992AbgIJOXL (ORCPT ); Thu, 10 Sep 2020 10:23:11 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9E14CE66F1FAABCAC9F1; Thu, 10 Sep 2020 22:06:58 +0800 (CST) Received: from huawei.com (10.175.127.227) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Thu, 10 Sep 2020 22:06:48 +0800 From: Jason Yan To: , , , CC: Jason Yan , Hulk Robot Subject: [PATCH] drm/i810: make i810_flush_queue() return void Date: Thu, 10 Sep 2020 22:06:10 +0800 Message-ID: <20200910140610.1191578-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: drivers/gpu/drm/i810/i810_dma.c:860:8-11: Unneeded variable: "ret". Return "0" on line 885 Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/i810/i810_dma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c index 303c2d483c6e..88250860f8e4 100644 --- a/drivers/gpu/drm/i810/i810_dma.c +++ b/drivers/gpu/drm/i810/i810_dma.c @@ -853,11 +853,11 @@ static void i810_dma_quiescent(struct drm_device *dev) i810_wait_ring(dev, dev_priv->ring.Size - 8); } -static int i810_flush_queue(struct drm_device *dev) +static void i810_flush_queue(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; struct drm_device_dma *dma = dev->dma; - int i, ret = 0; + int i; RING_LOCALS; i810_kernel_lost_context(dev); @@ -882,7 +882,7 @@ static int i810_flush_queue(struct drm_device *dev) DRM_DEBUG("still on client\n"); } - return ret; + return; } /* Must be called with the lock held */ -- 2.25.4