Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1400561pxk; Thu, 10 Sep 2020 14:29:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzODWqAxXBK9x77TzHF0gYNnrZkRwU3W7bR/2GPlNVnxw0MLCPaZI5tqM2j9AwtNF5uoSKn X-Received: by 2002:a05:6402:326:: with SMTP id q6mr11547921edw.216.1599773368037; Thu, 10 Sep 2020 14:29:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599773368; cv=none; d=google.com; s=arc-20160816; b=BjbHCgxKINhr0Q53lWYfhRwYyiQA2dWwMeEcmP26z0h7rADmMBEWK4XsJd69VYMYIH 4bDRBU5riXPM9WclBBXuFzsXCJz087a+HkQTLak++jSXsrw5p6bMRuQPeJKROK5meB2w jIjsiuig8LjDIteOdGlp2X9JQ/BqWK5J6IctcRVq6C2au/Mb+roMvhjd0fKMKWeAR1Zv JGR7SpC9MTwG1utkdif5t36cY/zb9B7oS5a7VWA1BOLgeUFq1H8HmSJWEl6pCfNGgUR1 szVFEl1cc6ctoGBO6/h/9LZDkh5qxeWPNqlNQYuZV3XHwHgblb0Ua1rEOWe1A3jj+sbv 2fPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZGzF0Xu/kyYiZnlJT/vKyAd5HwuZiUoBERsbi2uJqpE=; b=LjO3Kh089rOZ36SONrB+R5G+Niju4G2KqG9EXoFWovZ1eC3v9/XtwyGh4nZCmVNvgm r9W33vI39yRpdH2B47UIqlV6L+rF+G7wgN44Y5kiXq2wh1nu5Mc+Lf+Wf+fqenZ1xXbY LnQvVdKc6k8i4LQ1V0jllRLP6lmMFVMwHMWEmGEme+OUCUqbghBPqKklAY0dQ6ao4sxK 8cPWOgqKIbL3N2Kmvwb2eNp1WyRGOJbQ91ri6sOyD/a9UrEHZYqrDBxZUpdgapb4uJ5d VbNHBf4o34HJefnn7FXcfqjHfc52rtVNo8rBgQtGW4WXCzFSImQhmt3MqdCGShYI8SWQ rsMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BAfnSibZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pg3si4577854ejb.138.2020.09.10.14.29.05; Thu, 10 Sep 2020 14:29:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BAfnSibZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728210AbgIJV0i (ORCPT + 99 others); Thu, 10 Sep 2020 17:26:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:45832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731068AbgIJOXG (ORCPT ); Thu, 10 Sep 2020 10:23:06 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 885CE2075B; Thu, 10 Sep 2020 14:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599747727; bh=Sf1qebIUqiaky7hv/BnFelFwbArV0b890mZdIPxHgfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAfnSibZvJFwZ5iViUavWC2EqcP/X1N1HUfi+qrjt0yNALHtsLMs+EZIDJcUzJyqY /ZmyEI18F/rIQV2QXTumUdsuxI4Ai9tY7IHyz4uLe8kbjjXw1jxjpU11e71fCtHh0k 9pGFi9nLMwTB/FL7ASk40CzRyP/ItUCctdwvSoWs= Date: Thu, 10 Sep 2020 15:21:21 +0100 From: Mark Brown To: Shengjiu Wang Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: ak4458: Add DSD support for ak4458 and ak4497 Message-ID: <20200910142121.GC4898@sirena.org.uk> References: <1599747032-20055-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qtZFehHsKgwS5rPz" Content-Disposition: inline In-Reply-To: <1599747032-20055-1-git-send-email-shengjiu.wang@nxp.com> X-Cookie: I disagree with unanimity. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qtZFehHsKgwS5rPz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 10, 2020 at 10:10:32PM +0800, Shengjiu Wang wrote: > ak4458 can't support DSD512 format, but ak4497 can, so add > a new variable in ak4458_drvdata to distinguish these two > platform. > In hw_params(), calculate bit clock according to different DSD > format and configure DSD register. > + SOC_ENUM("AK4497 DSD Data Input Pin", ak4497_dsdp_enum), This control name doesn't seem to match up with the description - it's talking about a pin but the description sounds like setting a different format for the data? --qtZFehHsKgwS5rPz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9aNmAACgkQJNaLcl1U h9BvlQf/eYFovk6PSnGjHMoTkXtDd6ZSB8Bjxc2PaaM25GOwNdAcktYXdamyEJM6 8w+4vwJdhd4xAgWbaO9KAOdoyfrGCPqSEmv3Q97DT/gZRQ3xAAlyujp+5M4tE0QI O9GMTIJsvZO7UtU9izkr8vuwA1W/1HoTmHVmLQ6XcjP3h/z0R8dn2BqxKZKLlN9i SkbS+otZRdb0bBP3sDSVXdRn5T4RREx3BQEQOjzHEcIhJEuviqrc47/A9VcrUjfs pf7VFaoeNZCjGUy0CDeLElP3UtQQMMc6RWsPPdIk1QOlMAdy6j3/BYtxa7ubbqcR xV7s7W5Gf1fTY+siHZzyoPPCQ6M5RA== =tBUD -----END PGP SIGNATURE----- --qtZFehHsKgwS5rPz--