Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1404800pxk; Thu, 10 Sep 2020 14:37:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2KU6bya1xzwPs625wnRa1rxnEUS/58AtRmiqzYln3ZLWI95SBz7V+R4Tvgi8aTXyLi5Ku X-Received: by 2002:aa7:d593:: with SMTP id r19mr11904483edq.331.1599773836962; Thu, 10 Sep 2020 14:37:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599773836; cv=none; d=google.com; s=arc-20160816; b=HZ9D2Uyv2x2OyKqglCsnFJJ2h5S76wuYj4hDPqL9rcnH33dADl6JKyXO4KPq6tb97/ KPN6ho5v4ht7VwZ549syzyT19rA5M2gKK/D8QhYRlR6Y9FGqkXSzo62KuSacfsOPVXQx XrrYhYlh53id8jdGqyvovyX8carxp1tRJ0qzfJDckcA/uNLxq+gyQTbkoLqxuYyUYgq5 zcdARhK1/90PQTCF3NbjWsA1N7FNEJOxzQ1U/vfrwsVDLEbIH9B4teg8UubJp8FpoxN2 2+7muKV+ahIhZmF7vPAurxtu03bb8nReJq6YSVNdsV2B6N6srZR049tCsvE7ERgTjLne htWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=z6ICEyEfVJ6i08spBPZNyORnBHkc75iBiecbGLIyUUE=; b=eZLdxzVEvVrH3BztVSs/xz/Msbm4cwxYbapMsyuljtMhh3P/VgyFyIKecJzzD9gpZC HEkhVBw429L4Jpw9oSmRguZzRvJbeYz+p8zfTWob9ImnFtB5CFqlD9Md+EMLsriWCpvg NaiQXJmg9P2G851lhNhfJmaQfDsD4NJ2gh7DE3mgxxd0A4XpPkzDzHIbDY7AqrJjXcxu znIwqPXH9uyH3JSS0Bhg0iTOFKGnU2Aobm0MQh1LMNVRHEm5c+CN0TWbR3zfdv3aNF5I ycUxoH1z4AllPFMZz3L3p14DNO5K0ELRqKQQysZjl3SkL1jbgPiWg2h2OQ6JRpQqEg0Z w99w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oy13si4372829ejb.481.2020.09.10.14.36.54; Thu, 10 Sep 2020 14:37:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728308AbgIJVeU (ORCPT + 99 others); Thu, 10 Sep 2020 17:34:20 -0400 Received: from foss.arm.com ([217.140.110.172]:36620 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730951AbgIJNuJ (ORCPT ); Thu, 10 Sep 2020 09:50:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 429D011B3; Thu, 10 Sep 2020 06:43:27 -0700 (PDT) Received: from [192.168.1.79] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 14D603F66E; Thu, 10 Sep 2020 06:43:25 -0700 (PDT) Subject: Re: [PATCH] drm/panfrost: Ensure GPU quirks are always initialised To: Daniel Vetter , David Airlie , Rob Herring , Tomeu Vizoso Cc: Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alyssa Rosenzweig , "Marty E. Plummer" References: <20200909122957.51667-1-steven.price@arm.com> From: Steven Price Message-ID: Date: Thu, 10 Sep 2020 14:42:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200909122957.51667-1-steven.price@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2020 13:29, Steven Price wrote: > The GPU 'CONFIG' registers used to work around hardware issues are > cleared on reset so need to be programmed every time the GPU is reset. > However panfrost_device_reset() failed to do this. > > To avoid this in future instead move the call to > panfrost_gpu_init_quirks() to panfrost_gpu_power_on() so that the > regsiters are always programmed just before the cores are powered. > > Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver") > Signed-off-by: Steven Price Applied to drm-misc-next Steve