Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1419359pxk; Thu, 10 Sep 2020 15:06:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNKxr0YcJmG0/wSVPsIKHV6uBTgGwe/6iavQwjt26HRnHcc94ugFfIGhtbGsGy7JdIMPFh X-Received: by 2002:a17:906:fb97:: with SMTP id lr23mr11360186ejb.257.1599775604970; Thu, 10 Sep 2020 15:06:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599775604; cv=none; d=google.com; s=arc-20160816; b=Mt+XNNy0qw0CctapeQ3ewSZlzKeG7VF29xXNEFp+yKiAH5TRgWb8Ilncr7WtylHXks YzbOxJEfu+bmd9O8ZVX5aajvl/r38EaNLYxbZtLhRGwFD3l4rQ84OTAfLfGKYDKNi0Qw VHHmq6oc9u5ZG5Cq63TFSbpT2a7fx1nJMvv10toZk+hnnUEvx8AS8CVExKw48NWycUHr Tdt86Ll1sucEqDWeTWcxt4zSFQ0BhDeEdbJdREl2BsdDjfbrzoHYT6b1RaZ+SJghJdsl 3y7syQIe0BU6wOIgjiqgwZk4qKSwdTj0edPlmMxE1lM8ci1VuzZaKiH6KX6xwINuik7s vvYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=5F4L/BtzQ8F4yM8Q6eX0vIZ4NXB176nOHwyVbo69BKQ=; b=yglc/sZj/JFwjKa4MruO4HeP0XgCnHgrlxFx5CQe5yz6BS7tsNOIKB8LJOLpD/gIwQ rRbLs5IddPo5fU5EAY7xG05NmNSLQ82tP+BqB7n9INkboGVfm20bTaMddBV/OFbsSyia gdhT0wzmkSSkpMmNB4mUVUzePtJnTvp0Z42UAaTW73yhrxKRK7njngRigVrc/bqeVN6A fdu59Yl5mf1+lIc/k0kVlm8ue56oOZK7BWRnd2E30bGn2XupmAXg6stFYNn86wGgSFYK Yr7ybVCTCYG3MV00RSiRLNNrp3fGLIOEPrkPV5rGTv1Dnr+XyoLjQ243eN3ndiQ6Bq/D SzQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si4314565edh.74.2020.09.10.15.06.21; Thu, 10 Sep 2020 15:06:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725767AbgIJWFv (ORCPT + 99 others); Thu, 10 Sep 2020 18:05:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725320AbgIJWFt (ORCPT ); Thu, 10 Sep 2020 18:05:49 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C9A0C061573; Thu, 10 Sep 2020 15:05:49 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0F7E9135A93D2; Thu, 10 Sep 2020 14:49:02 -0700 (PDT) Date: Thu, 10 Sep 2020 15:05:48 -0700 (PDT) Message-Id: <20200910.150548.696841576525551255.davem@davemloft.net> To: mayflowerera@gmail.com Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] macsec: Support 32bit PN netlink attribute for XPN links From: David Miller In-Reply-To: <20200910095609.17999-1-mayflowerera@gmail.com> References: <20200910095609.17999-1-mayflowerera@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Thu, 10 Sep 2020 14:49:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Era Mayflower Date: Thu, 10 Sep 2020 09:56:09 +0000 > - pn_len = secy->xpn ? MACSEC_XPN_PN_LEN : MACSEC_DEFAULT_PN_LEN; > - if (nla_len(tb_sa[MACSEC_SA_ATTR_PN]) != pn_len) { > - pr_notice("macsec: nl: upd_rxsa: bad pn length: %d != %d\n", > - nla_len(tb_sa[MACSEC_SA_ATTR_PN]), pn_len); > + pr_notice("macsec: nl: upd_rxsa: pn length on non-xpn links must be %d\n", > + MACSEC_DEFAULT_PN_LEN); > + rtnl_unlock(); > + return -EINVAL; > + > + default: > + pr_notice("macsec: nl: upd_rxsa: pn length must be %d or %d\n", > + MACSEC_DEFAULT_PN_LEN, MACSEC_XPN_PN_LEN); > rtnl_unlock(); Please do not spam the kernel log like this. Instead, report this info via netlink extended ACKs. Thank you.