Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1426005pxk; Thu, 10 Sep 2020 15:18:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxliJPU9SypKfeeKh2BT/UwXQqRyihP8eDVfp5aO19pvixA4yzdWSR2WeeQQMVYZ/uUAoF5 X-Received: by 2002:a17:907:2168:: with SMTP id rl8mr10989533ejb.308.1599776312362; Thu, 10 Sep 2020 15:18:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599776312; cv=none; d=google.com; s=arc-20160816; b=ooxDtD6ws7yk0fjz0k7ZId0BQmXVW8FDMRjAKpVvTc/RYgjFLBinwxGo7692E5Pfs8 U4+ZOkEYWHgbaQyuwahUP1mzWwR+2Ym/yhl9jkwecdK0WOuE43TKPL7bODUpAkMbGb8Q paWY0SuEaXAkyZqU8Qm6q1IGrTg6ktxUJy4pcAH6fw/LqVEV/m/R/b+ccGHGi70xIJOz sbDjjTFWrI7phvRiOm1dt7hiBzO2Y3fGh12yTrwksgLPwd29+M466gcxT5SLukrTPPDn CNDRl7JUuMUZsDYTTa/TOHNpnyqcOs03jFwkUb/Oy2k/m0O2Bczlvqj5IHyaCu43eeIV 93GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=hZnIELPHibj4jSZ3irSbVafdLM/lD3R12v0thZgRV10=; b=anhSHOD/pAiBid88NltppNYnkWFKwAtlYOCrz/N/BfjZIyXIs0PzGuMsCrMikMBK8m EyIl4or8YIr0WHOVBAiwtqbwRjVURFH6JQMX9QEGR8O+Lw32mgyRtARH1p2dqRnoEeQR 5uwhdIdjSvIlpYAIrlcG1H904RZWpiFxbwQoNQJXQ37EaO8TTqGCYfZqlE+mNXiZ0rd2 WdmZUSsVlEYZPL4SGnbkEmt28eihpXwZtbgM59FJPbQIbKLbWZZegboBKnEKFc8TyJG5 UyC5vmVtfI6EEIkTVas0Enw+LHSloI1lDaV0e3kBMMHXCuY7Z7do7LhvOJMDbhb/qYyU xpZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si4789591edy.385.2020.09.10.15.18.09; Thu, 10 Sep 2020 15:18:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725813AbgIJWQK (ORCPT + 99 others); Thu, 10 Sep 2020 18:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725294AbgIJWQJ (ORCPT ); Thu, 10 Sep 2020 18:16:09 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BC32C061573; Thu, 10 Sep 2020 15:16:09 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A43D4135E9FF1; Thu, 10 Sep 2020 14:59:21 -0700 (PDT) Date: Thu, 10 Sep 2020 15:16:07 -0700 (PDT) Message-Id: <20200910.151607.1755041538732050239.davem@davemloft.net> To: alex.dewar90@gmail.com Cc: kuba@kernel.org, rmk+kernel@armlinux.org.uk, mcroce@microsoft.com, sven.auhagen@voleatech.de, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mvpp2: ptp: Fix unused variables From: David Miller In-Reply-To: <20200910134915.46660-1-alex.dewar90@gmail.com> References: <20200910134915.46660-1-alex.dewar90@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Thu, 10 Sep 2020 14:59:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Dewar Date: Thu, 10 Sep 2020 14:49:10 +0100 > In the functions mvpp2_isr_handle_xlg() and > mvpp2_isr_handle_gmac_internal(), the bool variable link is assigned a > true value in the case that a given bit of val is set. However, if the > bit is unset, no value is assigned to link and it is then passed to > mvpp2_isr_handle_link() without being initialised. Fix by assigning to > link the value of the bit test. > > Build-tested on x86. > > Fixes: 36cfd3a6e52b ("net: mvpp2: restructure "link status" interrupt handling") > Signed-off-by: Alex Dewar Applied to net-next.