Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Sep 2020 10:27:43 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        Randy Dunlap <rdunlap@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 0/8] tracing/boot: Add new options for tracing
 specific period
Message-Id: <20200911102743.de29a1f09bcb361f8d6556f6@kernel.org>
In-Reply-To: <20200910193433.236cf081@oasis.local.home>
References: <159972809455.428528.4737752126800169128.stgit@devnote2>
        <20200910193433.236cf081@oasis.local.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 10 Sep 2020 19:34:33 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 10 Sep 2020 17:54:54 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > Hi,
> > 
> > Here is the 3rd version of the series to improve the boot-time tracing to
> > support kretprobe and tracing_on option. Previous version is here:
> > 
> >  https://lkml.kernel.org/r/159894698993.1478826.2813843560314595660.stgit@devnote2
> > 
> > This version adds uprobe %return suffix support ([5/8]) and the testcases
> > ([8/8]), and update kprobe %suffix support([4/8]) and the uprobe event
> > document([6/8]).
> > 
> > 
> > The combination of tracing_on and kretprobe allows us to trace events
> > while a specific function call period. For example, the below bootconfig
> > will make a function callgraph in the pci_proc_init() function at boot
> > time.
> > 
> > ftrace {
> > 	tracing_on = 0  # off at start
> > 	tracer = function_graph
> > 	event.kprobes {
> > 		start_event {
> > 			probes = "pci_proc_init"
> > 			actions = "traceon"
> > 		}
> > 		end_event {
> > 			probes = "pci_proc_init%return"
> > 			actions = "traceoff"
> > 		}
> > 	}
> > }
> > 
> > Here is the example output;
> > 
> 
> [..]
> 
> Hi Masami,
> 
> This looks really great! I just got back from a 10 day holiday, and I'm
> drowning in "catch-up".  I plan on looking at all this relatively soon
> (in a week or two?). I just don't want you to think I'm ignoring this.

Hi Steve,

Thanks, I hope you enjoyed the holiday!
BTW, this series includes some document update and testcases.
Since we can not decouple these updates, I think it is better you to
pull the series.

Regards,

-- 
Masami Hiramatsu <mhiramat@kernel.org>