Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1539306pxk; Thu, 10 Sep 2020 19:10:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkH3s8na6kexYQqW43J7i23tDJL1R9Ohw5r/6lnA7bZ3Lhepg/RNyWym9C53D5M5kehacU X-Received: by 2002:a17:906:d965:: with SMTP id rp5mr11391384ejb.364.1599790200056; Thu, 10 Sep 2020 19:10:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599790200; cv=none; d=google.com; s=arc-20160816; b=i8jeJoFfsYD9GE5l1KqsrgDr9vVhsX0lhX2rAVOu/1cL5yj5EPgIhSKfyrI06LrQfI QH3UOY3/OKzq7XGBmqmuQo2GuR4hKf5yAp5YmPgbzCInMKkfrArAVH0/h9snCgYheEnM PkAQTkDhduOJEe/YRdMx3DVFQdsKoQyyhj7ep+/Nzce+aqMLUun0WK23Ax6wdKuo7zMn kb5v9nmLbvEHTYj8jtR3zVx2P6dTrxV30cp4RxaxEvalaKHjHZNRtgodemgK2sy0UIgp K5wp6qx+sc85VwmmfdAK843X9usfyjleziCMh6Rqrapj+IGc6ElaJ+luP9e46neumgU1 dXEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=xBlLHpGk76ucdSdRK4k1OYX19NiC7unxU/9CaubDVqE=; b=G3HgKmBgH5FMfpyzAyZIEJjP3jJQGBWnXTwnk1OVJbKDp0R1WZzSN5T+x4z+0/L4mR RCY2KQ/u5z/jmLLWGqDw2IbeEfbJffvnjig1+S0aSRgi+8e8NKe3WB2K6WqKsLqiBceZ Eulid3yhVon20rbZM10LntVjKH7dLx9tjzjl/i+rw9c5t6b8xguqefazHAICMl5lKW5T UtkVSwyBBCIlPpPiw4uN+n5OamWdZYy+BEUCvO64gKylXzXX+pvqDq0m8C8HIQyPwUFn HhFS/a0i53+GMkkByQA0+nk+uit4YeY+AdLwG6q0YawgyUscpVi7etvGV4ECRxasxe0A zPDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mc3si347244ejb.404.2020.09.10.19.09.37; Thu, 10 Sep 2020 19:10:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725782AbgIKCGj convert rfc822-to-8bit (ORCPT + 99 others); Thu, 10 Sep 2020 22:06:39 -0400 Received: from smtp.h3c.com ([60.191.123.50]:12561 "EHLO h3cspam02-ex.h3c.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725298AbgIKCGi (ORCPT ); Thu, 10 Sep 2020 22:06:38 -0400 Received: from DAG2EX07-IDC.srv.huawei-3com.com ([10.8.0.70]) by h3cspam02-ex.h3c.com with ESMTPS id 08B26Hbl001293 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Sep 2020 10:06:17 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) by DAG2EX07-IDC.srv.huawei-3com.com (10.8.0.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 11 Sep 2020 10:06:18 +0800 Received: from DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074]) by DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074%7]) with mapi id 15.01.1713.004; Fri, 11 Sep 2020 10:06:18 +0800 From: Tianxianting To: "viro@zeniv.linux.org.uk" CC: "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size() Thread-Topic: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size() Thread-Index: AQHWg1VbepwpzeymnU+ybaV+ROAJcqliuT9Q Date: Fri, 11 Sep 2020 02:06:18 +0000 Message-ID: <3808373d663146c882c22397a1d6587f@h3c.com> References: <20200905071525.12259-1-tian.xianting@h3c.com> In-Reply-To: <20200905071525.12259-1-tian.xianting@h3c.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.99.141.128] x-sender-location: DAG2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-DNSRBL: X-MAIL: h3cspam02-ex.h3c.com 08B26Hbl001293 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi viro, Could I get your feedback? This patch fixed the build warning, I think it can be applied, thanks :) -----Original Message----- From: tianxianting (RD) Sent: Saturday, September 05, 2020 3:15 PM To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; tianxianting (RD) Subject: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size() Fix warning when compiling with W=1: fs/read_write.c:88: warning: Function parameter or member 'maxsize' not described in 'generic_file_llseek_size' fs/read_write.c:88: warning: Excess function parameter 'size' description in 'generic_file_llseek_size' Signed-off-by: Xianting Tian --- fs/read_write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/read_write.c b/fs/read_write.c index 5db58b8c7..058563ee2 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -71,7 +71,7 @@ EXPORT_SYMBOL(vfs_setpos); * @file: file structure to seek on * @offset: file offset to seek to * @whence: type of seek - * @size: max size of this file in file system + * @maxsize: max size of this file in file system * @eof: offset used for SEEK_END position * * This is a variant of generic_file_llseek that allows passing in a custom -- 2.17.1