Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fs: use correct parameter in notes of
 generic_file_llseek_size()
To:     Tianxianting <tian.xianting@h3c.com>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Cc:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20200905071525.12259-1-tian.xianting@h3c.com>
 <3808373d663146c882c22397a1d6587f@h3c.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <07de1867-e61c-07fb-8809-91d5e573329b@infradead.org>
Date:   Thu, 10 Sep 2020 19:57:24 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <3808373d663146c882c22397a1d6587f@h3c.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/10/20 7:06 PM, Tianxianting wrote:
> Hi viro,
> Could I get your feedback?
> This patch fixed the build warning, I think it can be applied, thanks :) 
> 
> -----Original Message-----
> From: tianxianting (RD) 
> Sent: Saturday, September 05, 2020 3:15 PM
> To: viro@zeniv.linux.org.uk
> Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; tianxianting (RD) <tian.xianting@h3c.com>
> Subject: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()
> 
> Fix warning when compiling with W=1:
> fs/read_write.c:88: warning: Function parameter or member 'maxsize' not described in 'generic_file_llseek_size'
> fs/read_write.c:88: warning: Excess function parameter 'size' description in 'generic_file_llseek_size'
> 
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  fs/read_write.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/read_write.c b/fs/read_write.c
> index 5db58b8c7..058563ee2 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -71,7 +71,7 @@ EXPORT_SYMBOL(vfs_setpos);
>   * @file:	file structure to seek on
>   * @offset:	file offset to seek to
>   * @whence:	type of seek
> - * @size:	max size of this file in file system
> + * @maxsize:	max size of this file in file system
>   * @eof:	offset used for SEEK_END position
>   *
>   * This is a variant of generic_file_llseek that allows passing in a custom
> 


-- 
~Randy