Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp32066pxk; Thu, 10 Sep 2020 22:38:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/f+qA9s6Uwqa/VpDGTZXrxGj5z0mgS/UNorMY7VZFajMGet/UVGqR83ZikaLCh1tbps0A X-Received: by 2002:a17:906:e24d:: with SMTP id gq13mr440507ejb.152.1599802691611; Thu, 10 Sep 2020 22:38:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599802691; cv=none; d=google.com; s=arc-20160816; b=P7uieAbgzKuVv2RUOoY+cXogzEMpToHyS9euM3kvzlFEEBKnuEwNHWFC0zr0ujLg58 39tLBW5uyFyyU95mb/DuG9YM3U4t2m/rOXADzNi/WUfqH9n4JzJWF0fYOLzV7B4XXbRm 5XMyo2hJPiA5Gncg8kwitonMt9x2QBjDfxaX+AAUkmvH1/HRmbm35p59VrAEHd+UzrBf vO4HBehwkqsVwHXZmIg1Ee52qYyEMjddHIKD75yvbjUgpsBVGEo0dXSdU2PEV0O4Jy3U TpmtZyXgverQ9L6wZkN3csowYvpn/BDGxHHIE6/QOsRyMQIRkpXwr2bFs93OXCDhtxCU TxFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=gQphWQCU5VjNrWDqCFqtQ550fk5he6cvU1opUnwp6c8=; b=CzEhbBDN4koZTC0gr7ZmR+bb1ue/mSbau0DrtXDhIybLMCFIvlcL61iLHwHP0oKyWe B8/Q1kZb1H7njP3pLycWbxVRIRsWCCdJToNuv7SU4BoDeGfwC/La1fW8Aby/WfpESGDE d/R6xGgJBIaqCEgguu3kcX1vwry2dQqhZHWk53lVx7ReCF45tJyIetD5H5WCa+jcp/u+ x1p2UCwwrfxPzDOJ1H+ZtK+gO53WELAvEPfkVr33xUSs908SIBdZQ78noQE2qgjW/cKe gJBIFr8vzv2leOoLm/u9zAvNkACnjRixuP9+K5BFYeBLBNkk9s1vqunH+AivMJk9wt/o inaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b="TtW8Tw/A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p11si537210edy.306.2020.09.10.22.37.49; Thu, 10 Sep 2020 22:38:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b="TtW8Tw/A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725781AbgIKFgz (ORCPT + 99 others); Fri, 11 Sep 2020 01:36:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgIKFgx (ORCPT ); Fri, 11 Sep 2020 01:36:53 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3635BC061573; Thu, 10 Sep 2020 22:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gQphWQCU5VjNrWDqCFqtQ550fk5he6cvU1opUnwp6c8=; b=TtW8Tw/Awwjlz9gH0OBnuKs1qy 7ZLv4Qt3qKqoCfvga77I2/h5nvdFdHI9hpnYnu3Z9U0gdWLfS1wccy9ndxj/OGxCCy/w3dZm2/NqO VBRvwCWm9c4caIpKq4MW1M7BaX3GTDleILIrKUDRZ0AcDLXqQF5ylxpch3CePtqA4upeRwm5bOsLk KZDpL5J5/9rWDAwBp4mxpxL/QZmDvVgkeWDKlKnz9xZX3nOsZJ9I5AHk24TzOsfwvm6bR1TOM+lqP MOvya4XR6dE4YqtiRtFIdMEbjVNKiKFuCaoVeooODCme9uI8WHd++HAXBJSwGBh9hrkT1UoibW9nQ G7J6otAA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGbjv-00040M-0T; Fri, 11 Sep 2020 05:36:51 +0000 Date: Fri, 11 Sep 2020 06:36:50 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , Christoph Hellwig , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Dave Kleikamp , jfs-discussion@lists.sourceforge.net Subject: Re: [PATCH v2 6/9] iomap: Convert read_count to read_bytes_pending Message-ID: <20200911053650.GB15114@infradead.org> References: <20200910234707.5504-1-willy@infradead.org> <20200910234707.5504-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910234707.5504-7-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2020 at 12:47:04AM +0100, Matthew Wilcox (Oracle) wrote: > Instead of counting bio segments, count the number of bytes submitted. > This insulates us from the block layer's definition of what a 'same page' > is, which is not necessarily clear once THPs are involved. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig