Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Sep 2020 09:44:09 +0300
From:   Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To:     Wang ShaoBo <bobo.shaobowang@huawei.com>
Cc:     cj.chengjian@huawei.com, huawei.libin@huawei.com, agx@sigxcpu.org,
        l.stach@pengutronix.de, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] drm/imx: fix unused but set variable warnings
Message-ID: <20200911064409.7dyuda6f6uxglmwa@fsr-ub1864-141>
References: <20200911014414.4663-1-bobo.shaobowang@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200911014414.4663-1-bobo.shaobowang@huawei.com>
User-Agent: NeoMutt/20171215
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from fsr-ub1864-141 (83.217.231.2) by AM3PR05CA0152.eurprd05.prod.outlook.com (2603:10a6:207:3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Fri, 11 Sep 2020 06:44:12 +0000
X-Originating-IP: [83.217.231.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 7cd9684c-2cee-4c26-3790-08d8561e1822
X-MS-TrafficTypeDiagnostic: VI1PR04MB5263:
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS: <VI1PR04MB5263C43B5F2042CA539B82F0BE240@VI1PR04MB5263.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: iecPtqOpYP3ygfBp+1E1qkYoWBaQR0xnYUevBg1gaTjG7/cowy8pbNha+mTRJypHoAmq8jTW5A3021/PY6Nv/UsGewaF+rSCIV2HkrLw53j/6zflM5RVrys6fBDT4R+e/aiQpLWKt6DDRvuAqJrxSCfD9xbZbmeXZzPG9ZNwWUw8lzTny2WOVR8wEEPCgrudHmqJvv2hsY8mrF8I4v7m/ePmHv7Sfn7BzT3UqbGouXSB9E62Ggn+VBuYql/yDX7OsckWDPRywqPQc5MKUQIgyc9NPjp48u9qfHXBzYPzZRy8mDEft4B0RF+eNsRd1BFzNZ+0tZuNZe97jbEC5MbEYw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3902.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(86362001)(33716001)(4326008)(6666004)(52116002)(6496006)(8676002)(66556008)(6916009)(66946007)(66476007)(2906002)(8936002)(316002)(26005)(186003)(16526019)(5660300002)(83380400001)(1076003)(44832011)(956004)(9686003)(55016002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: eSGNXIXRfn27q7+qjctEBMH1OhZlf6T/r0SN+kiWTgujoEyMFjQ3W0rZYNziY/3qN2YF94llc5U/WDV7/5fWI/Cs6mgYLevzGWps11/bDOYHfszYRvrAZJHscYt5BtI6fdNPtGzrhFxmkvEGFtM3XGnFof0SKDkOKfNH5lsMyVaE/lIEvn0f01gdp0h/EZqS866Fxz5j9ekodNT3FjSs1RrzCT1H5IyaInJeTi5dlNP+9BavOowsYl5ImvL9uMFnSdIHFvhYaeP9r148koEFDsvMy9rAhFpGg4kKmoBZDd5o/VWS0utqyTaGDJeW+3JGZx3eGhXjwxB/+4/Bp/C3uC8c3grx1ofT2cH81ew53u2XyldZL/agxTL2X2nNKsxEdx7BNoGAYV4IyrWrlZTk252HWqHclZjlj5QWjxKQh345NnR7kC3hjCX0Kj38//FN+3mB+g24lBikm+20TT0JQjuaw+LUGTTWQdIOrNl6SzjS/ip3k0pE2juP+venGYXJeFkc2Z9dazPI7X4ZW8l+qOLcxvh/M0DiT+sJmQotvCICLkumxmqq4qUOkv1kDwnrwGQKym5DFEIK6ZjQmcf8fmJz+rDNURWpl5VTYrrq3Iz9De+EIum+F5w6SO8U3QchbwK4x62870CjqEihPpzjUQ==
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd9684c-2cee-4c26-3790-08d8561e1822
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3902.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2020 06:44:13.1775
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jm61WIrkb5Gr+Q+rZQia1ZPDS2VYpC0sIhm8IRHT1JaGkWH6Dt7bohjGjxX34inYGkJMUBa1M+a7M5+drH3IKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5263
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 11, 2020 at 09:44:14AM +0800, Wang ShaoBo wrote:
> Fix unused but set variable warning building with `make W=1`:
> 
> drivers/gpu/drm/imx/dcss/dcss-plane.c:270:6: warning:
>  variable ‘pixel_format’ set but not used [-Wunused-but-set-variable]
>   u32 pixel_format;
>       ^~~~~~~~~~~~
> 
> Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>

pixel_format will be used in the next patches that will follow the
initial one and I probably forgot to remove it when I split the patches.
But, I guess, we could remove it for now to make the bots happy.

Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>

> ---
>  drivers/gpu/drm/imx/dcss/dcss-plane.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c b/drivers/gpu/drm/imx/dcss/dcss-plane.c
> index 961d671f171b..e13652e3a115 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c
> @@ -267,7 +267,6 @@ static void dcss_plane_atomic_update(struct drm_plane *plane,
>  	struct dcss_plane *dcss_plane = to_dcss_plane(plane);
>  	struct dcss_dev *dcss = plane->dev->dev_private;
>  	struct drm_framebuffer *fb = state->fb;
> -	u32 pixel_format;
>  	struct drm_crtc_state *crtc_state;
>  	bool modifiers_present;
>  	u32 src_w, src_h, dst_w, dst_h;
> @@ -277,7 +276,6 @@ static void dcss_plane_atomic_update(struct drm_plane *plane,
>  	if (!fb || !state->crtc || !state->visible)
>  		return;
>  
> -	pixel_format = state->fb->format->format;
>  	crtc_state = state->crtc->state;
>  	modifiers_present = !!(fb->flags & DRM_MODE_FB_MODIFIERS);
>  
> -- 
> 2.17.1
>