Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp65232pxk; Thu, 10 Sep 2020 23:58:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHob/yz8aKcjPIJQ19qpCce51GPUFlSi8YnB2M1BW7xXtIYRCe9KrMbqxTyX19c7IMyKvZ X-Received: by 2002:a17:906:819:: with SMTP id e25mr691201ejd.211.1599807533832; Thu, 10 Sep 2020 23:58:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599807533; cv=none; d=google.com; s=arc-20160816; b=hendypIzZtnyBvv855TgVhX0uYSXYf+MorefFs8a3AQ8de5H8Mq1s7WO5BboqK5Lxv oGolXSpDovyaAmGsQz9Wu9TRf3y9x+o2hiTFbhxV+m8/NaoJ90ZG8+KZMZPvHxRUUo+1 aXJ6+/s3QGi1T4H7IpkSiUt7wraH02cBBsb5UIbCtm2eoH9J8qjltbp9JFTbpWAYAQCa I+c/H8zYawkXCPyMFfBS7r9/xGxr1NxbGdEAHiMglSnW5D/a44ckxtGFeWKF6GYvZ10i HoyFLTqlQaiBVXlV8Af9QNOyUBbqmCkW7EFmvZpi9TTfn6+MJWvbZe6N9eA3+bP8GHZ9 ep6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=AWt8e+Mw6r/7C0+LOLgGANF7RmbTfkJ8gpEXJHWIld0=; b=lZlFfRIOoegRrxERWJE9phK5F+Umg1lla4AkBQxNwsBzQ0P3kXxamAxuZGxC+hHnuc xvluzXJ0UEpYfRIwb/WYvtxGnHaREeJCpHGUwRxU6EMApa8vArZl6tvzKevf24p5BfdX 0fn0qbI1/j5FxenDadEwChHsk2bViXZAL5hh/I1cb4Dezlbqdkq/Kd8kWncM0bG1u9Aa cxmoGKmMqEpGvnlaIOXqaRKL/86EHyo8iw0sMGbVbprtiG4lav2Sf9bVDtkiaWoHruob 1pbMjVIDK3pD0La4pOCDVey1Mj1XX4ajJMCwEPR5QAmcM/DVwRPQXmv8MWyKjWnCr9cI LlVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=G6cv9eis; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha21si739332ejb.147.2020.09.10.23.58.31; Thu, 10 Sep 2020 23:58:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=G6cv9eis; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725554AbgIKG5k (ORCPT + 99 others); Fri, 11 Sep 2020 02:57:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgIKG5h (ORCPT ); Fri, 11 Sep 2020 02:57:37 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A24B2C061573; Thu, 10 Sep 2020 23:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AWt8e+Mw6r/7C0+LOLgGANF7RmbTfkJ8gpEXJHWIld0=; b=G6cv9eisU0LtwkwwXlXiXiLdhR jmkKpqdBGd+Qsm4IhkTCC+p4FisKqwrSIcQ4WzxXmnBQb9HShW57MDI2CdCBOdt87/PmEA5cd9RQd TMmlAZqktVm/kEMuPzfQLN6RswYqw39EhZlX5KU7J25019UQo+TZ9NNqY0OUl7J30W7nlPw98UHFt m7TDXq7b/WBrv4qgahljvhYOrkyhjvVvZrJ/FqWUlZMZ7u/91o+NY6w8beXkrZpfBZJPQbjVLqnig 5Mvvi8c7ai5K+fu26Utfic43zLfLMYIRJ+6ZpDxMbfWG6tY1zXJtg1Y0LCplMKVTRNP3F8j+Ngla5 e0EL5+6A==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGd01-0000HK-76; Fri, 11 Sep 2020 06:57:33 +0000 Date: Fri, 11 Sep 2020 07:57:33 +0100 From: Christoph Hellwig To: Rich Felker Cc: Christoph Hellwig , linux-api@vger.kernel.org, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfs: add fchmodat2 syscall Message-ID: <20200911065733.GA31579@infradead.org> References: <20200910142335.GG3265@brightrain.aerifal.cx> <20200910162059.GA18228@infradead.org> <20200910163949.GJ3265@brightrain.aerifal.cx> <20200910164234.GA25140@infradead.org> <20200910170256.GK3265@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910170256.GK3265@brightrain.aerifal.cx> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2020 at 01:02:56PM -0400, Rich Felker wrote: > Would you be happy with a pair of patches where the first blocks chmod > of symlinks in chmod_common and the second adds the syscall with > flags? I think this is a clearly understandable fix, but it does > eliminate the ability to *fix* link access modes that have been set to > ridiculous values (note: I don't think it really matters since the > modes don't do anything anyway) in the past. I'd be much happier with that, yes.