Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp70523pxk; Fri, 11 Sep 2020 00:08:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8jNzhn2LkADyCjMZcUqmYOv+TftxdZ20z9632Sdr8BKKaGJ+IH+cY/S0WFVJ/kfx5gDFn X-Received: by 2002:aa7:cc14:: with SMTP id q20mr562474edt.309.1599808133568; Fri, 11 Sep 2020 00:08:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599808133; cv=none; d=google.com; s=arc-20160816; b=hsNoIGcOtA0lNlBjvCAEgLOSXppe1/1tJEOaQ47OW/QwtCrmKOLUgAG1R/6x+vRz/D Ke2Gq5KJOcrXDn1ZSrb/55V1sE61Ojoq8raTqckPLWsnju12/tI6oiaeHN3xYfD+dRXT OzwePsbLPPyb5cBuG4OaGpdyVWPJeUDty7iy29rQvV8Tyrg7YYTTD5FyrOX8m66V6Ag4 LI4X2/oDNHQZkgBRVtMUQX9z+ypWRvSrOAcn7zE8O8U5LwliJr0XsbEbY6dosCcRZD0e A5LOosYm6coBe69BPCt/c0frVQAzTDoEqbmuM5WoCLJFLTvJGpfxHPswH5+ToEBMP1a0 miGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qB8kWX3+t8CoI+m4472E23kfVhNj8WiyLg7U5iNkMf4=; b=athq+ec4DzLAha37zV5nvWdUX5etsq42oJ9NwbEWpJOyMRUl+9U8bxUuJgfj2gecp9 UZWwJKWUOxsEG3Hzm1SGpLlYVnmxiYHRD0nmE3MYiER7EX5F7V8VN+gQ4y5RWULFDLwJ WO12Ye2DZWyqGHMUdMIW1FJr3R58ncpWDtIPrIMbOZq089pUAZRsi/zAVzDq4994dbm4 dp0IMpVRfLb1lsVPXorW/2NvVdIuM+b7qPAPWC9tdq3njgxtGbF1xEaWffjESdEt7p5Z jEYPl0E7N6SvEPG25g2dmK+doplTc4fms2+kvizMU4JMG2movJdqQRmuHmF54o+nqlz3 JUQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c61si750055edf.394.2020.09.11.00.08.30; Fri, 11 Sep 2020 00:08:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725768AbgIKHHj (ORCPT + 99 others); Fri, 11 Sep 2020 03:07:39 -0400 Received: from verein.lst.de ([213.95.11.211]:35740 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgIKHHc (ORCPT ); Fri, 11 Sep 2020 03:07:32 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6D8E568B02; Fri, 11 Sep 2020 09:07:30 +0200 (CEST) Date: Fri, 11 Sep 2020 09:07:30 +0200 From: Christoph Hellwig To: Hillf Danton Cc: Christoph Hellwig , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 03/12] MIPS/jazzdma: decouple from dma-direct Message-ID: <20200911070730.GA22394@lst.de> References: <20200908164758.3177341-1-hch@lst.de> <20200910141233.10768-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910141233.10768-1-hdanton@sina.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2020 at 10:12:33PM +0800, Hillf Danton wrote: > > On Tue, 8 Sep 2020 18:47:49 +0200 Christoph Hellwig wrote: > > > > The jazzdma ops implement support for a very basic IOMMU. Thus we really > > should not use the dma-direct code that takes physical address limits > > into account. This survived through the great MIPS DMA ops cleanup mostly > > because I was lazy, but now it is time to fully split the implementations. > > A minor change in behavior, do we need to clear the dma buf as the > dma-direct code does? Yes, I've fixed this up.