Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1599747032-20055-1-git-send-email-shengjiu.wang@nxp.com> <20200910142121.GC4898@sirena.org.uk>
In-Reply-To: <20200910142121.GC4898@sirena.org.uk>
From:   Shengjiu Wang <shengjiu.wang@gmail.com>
Date:   Fri, 11 Sep 2020 16:19:36 +0800
Message-ID: <CAA+D8AOo7rV0omvZdXNRK15ZdK+H-oU8SVxinZTGPusAzfv-Kw@mail.gmail.com>
Subject: Re: [PATCH] ASoC: ak4458: Add DSD support for ak4458 and ak4497
To:     Mark Brown <broonie@kernel.org>
Cc:     Shengjiu Wang <shengjiu.wang@nxp.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 10, 2020 at 10:23 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Sep 10, 2020 at 10:10:32PM +0800, Shengjiu Wang wrote:
>
> > ak4458 can't support DSD512 format, but ak4497 can, so add
> > a new variable in ak4458_drvdata to distinguish these two
> > platform.
>
> > In hw_params(), calculate bit clock according to different DSD
> > format and configure DSD register.
>
> > +     SOC_ENUM("AK4497 DSD Data Input Pin", ak4497_dsdp_enum),
>
> This control name doesn't seem to match up with the description - it's
> talking about a pin but the description sounds like setting a different
> format for the data?

I will add more description. Thanks.

best regards
wang shengjiu