Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp107312pxk; Fri, 11 Sep 2020 01:34:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg1cgY/05aQWhTs+87Oq8X6iKBc3veNzNMWIUsbvMcntRFcC8QGY8B56RzxB6nsyz8x7Kk X-Received: by 2002:a17:906:33ca:: with SMTP id w10mr1047467eja.438.1599813240400; Fri, 11 Sep 2020 01:34:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599813240; cv=none; d=google.com; s=arc-20160816; b=HQs9O/aUQ7xEVsY3bC7QFgq/3sMrMEth0RpawOWo92l63iJMvs/H0FkyuENulKe2Mw imKMpj4DUVov31aKwFQGClXDqqMVBftaMtRyAxQJ/2thvR2hxSL43HPQUG/33pQ3MDBN aOGNxz/IQvJhHJ0bQtKLcOGvRYrZ0ZOU+qmR5jD7gxGO+jlu39gF+GbrHSe3LYIjwK70 1XY2/Q8fKUCki/Dv7ZnvK5PEMrKFwInfva25E7t1iTRx2G4qUeNW06GFtKbbLXk9k9HB gS85BQ1rfDTQg+AmDB5JrpD6DZ0YuZPIi0IRx1gX68v5GLpa64vPmC2+qVDYii0VF2KR C5MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=Z1BdTesaiWepAKQgkXe2/VRpo4TMuPhA/hVEY2EsNes=; b=w+ZoKKi0c/vIF3wLNEfC4KMysZiVZ2TdzlvsFWCEh265rtSPkucEfb9tONX+7XCtO9 kchDhdGMrghvRKYKzRbGuuTZ4MMlTfJ8lczLF21sg5ZVTsu443eMAloS4nkB+jzMRoxw oyv/PFfPP6U1dzZT4fHgzds1DUrDiuqCqLqZRRjK/EuvhJinIh+ZhHXBbOvjkK8tmn6l JM7wmZm5nvtU2iwqKLV5MkKre2Tqy1+K6TGwehzdUqITpExztIu88+WbJ/vNDKvHQNUh Gq69rgh3nzH/OUowMg/6Z0DWv0cxsJU4x/wPkqT9ylAeQOdlukm7LONOAuRusXCVcCva IOgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FCz4mf1T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q5si781817eji.118.2020.09.11.01.33.37; Fri, 11 Sep 2020 01:34:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FCz4mf1T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725777AbgIKIcz (ORCPT + 99 others); Fri, 11 Sep 2020 04:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgIKIcw (ORCPT ); Fri, 11 Sep 2020 04:32:52 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ABD7C061573; Fri, 11 Sep 2020 01:32:49 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z4so10625848wrr.4; Fri, 11 Sep 2020 01:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Z1BdTesaiWepAKQgkXe2/VRpo4TMuPhA/hVEY2EsNes=; b=FCz4mf1TvXnhkZPG/EKBmAkSoRy5n5UqUUUpOwRLyvwAtExoj8ag/7DIFuQeT2UIYe 9Nvp9Bv6lDlBJ8/DYVSh64kfGwYlCtX5o4u3FB6qTTSlyN6cbbjn0iXF8MkhmZu41HAV x8EHJyqiSpZIDJq2P5xd+uSbehV5X48vfLya8VHaZfWUSN/k1khSA2f9xjVBmIsASwmd 3qvX1pK8c+odgguYiVr2a4f/7DNbGQXjvsiQEsmeXgbtgkubn9g0jEQZidJViLIcL1AE mIK5tajmdP9aQbtudrR8hI8eOfZ9lYxKdLiIsi7V8Xm/zQl/qKxS1xpywLR0+j4Ltep5 Sw2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z1BdTesaiWepAKQgkXe2/VRpo4TMuPhA/hVEY2EsNes=; b=MMo6uNeec/dCvCdflOEfVjX1hm5gbzT2NrqtKxgjzWUtoWVkJ7awVsJXtg+gLNvjSn cngKDSC25nKvtqMKNNqK+oyWujizNH9so3MmD61vMYt5fuOP5Y7yK3bG23pvcE4XUoz+ +2UZyjDXJq/iYJB945m2F7YboBiA8QfskhJs5+Z7cO5aW1MUr+JMc6i3KMoc6Y9L71HV 7otCBKLJQklidN3EP9ne6h4TONW7KKaQj4TrpkO3tyhIM6nZno0kTGneU6BUK5YkJWHy dQP7Z/p55DiBcp/SEy8be/dWv1wd3/zc8mV1xUsLLdFYiTDEqaxOFCfT+Y7hQVpe5O4W q/5w== X-Gm-Message-State: AOAM530ax1WV76fzrS8NETLlI4OoWORJzNPMfe5q2pwtyMs7QeuZfyAD KYTiIf9iDuPBKoGRTT+dUTvaIuAfZwk= X-Received: by 2002:a5d:6a47:: with SMTP id t7mr875493wrw.75.1599813167695; Fri, 11 Sep 2020 01:32:47 -0700 (PDT) Received: from [192.168.1.143] ([170.253.60.68]) by smtp.gmail.com with ESMTPSA id l16sm3347215wrb.70.2020.09.11.01.32.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2020 01:32:47 -0700 (PDT) Subject: Re: [PATCH 19/24] pthread_setname_np.3: ffix To: "Michael Kerrisk (man-pages)" Cc: linux-man@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200910211344.3562-1-colomar.6.4.3@gmail.com> <20200910211344.3562-20-colomar.6.4.3@gmail.com> From: Alejandro Colomar Message-ID: <2c2150bc-d4df-e821-1717-6450540b6c71@gmail.com> Date: Fri, 11 Sep 2020 10:32:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, The indentation in the original code was a bit weird (specifically, the 'do {' part had one more indentation level than the closing '} while'), so I simply chose something nice. See the original page, and if you think it's ok keep it, else find something nice :) Cheers, Alex On 2020-09-11 09:58, Michael Kerrisk (man-pages) wrote: > Hi Alex, > > On 9/10/20 11:13 PM, Alejandro Colomar wrote: >> Signed-off-by: Alejandro Colomar >> --- >> man3/pthread_setname_np.3 | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > What's the rationale for this patch? > > Thanks, > > Michael >> >> diff --git a/man3/pthread_setname_np.3 b/man3/pthread_setname_np.3 >> index b206f66c0..4dc4960cd 100644 >> --- a/man3/pthread_setname_np.3 >> +++ b/man3/pthread_setname_np.3 >> @@ -164,8 +164,9 @@ THREADFOO >> >> #define NAMELEN 16 >> >> -#define errExitEN(en, msg) \e >> - do { errno = en; perror(msg); exit(EXIT_FAILURE); \e >> +#define errExitEN(en, msg) do \e >> + { \ >> + errno = en; perror(msg); exit(EXIT_FAILURE); \e >> } while (0) >> >> static void * >> > >