Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Sep 2020 10:54:32 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Jason Yan <yanaijie@huawei.com>
Cc:     airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] drm/i810: make i810_flush_queue() return void
Message-ID: <20200911085432.GQ438822@phenom.ffwll.local>
Mail-Followup-To: Jason Yan <yanaijie@huawei.com>, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Hulk Robot <hulkci@huawei.com>
References: <20200910140610.1191578-1-yanaijie@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200910140610.1191578-1-yanaijie@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 10, 2020 at 10:06:10PM +0800, Jason Yan wrote:
> This function always return '0' and no callers use the return value. So
> make it a void function.
> 
> This eliminates the following coccicheck warning:
> 
> drivers/gpu/drm/i810/i810_dma.c:860:8-11: Unneeded variable: "ret".
> Return "0" on line 885
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Queued up for 5.10 in drm-misc-next, thanks for your patch.
-Daniel

> ---
>  drivers/gpu/drm/i810/i810_dma.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c
> index 303c2d483c6e..88250860f8e4 100644
> --- a/drivers/gpu/drm/i810/i810_dma.c
> +++ b/drivers/gpu/drm/i810/i810_dma.c
> @@ -853,11 +853,11 @@ static void i810_dma_quiescent(struct drm_device *dev)
>  	i810_wait_ring(dev, dev_priv->ring.Size - 8);
>  }
>  
> -static int i810_flush_queue(struct drm_device *dev)
> +static void i810_flush_queue(struct drm_device *dev)
>  {
>  	drm_i810_private_t *dev_priv = dev->dev_private;
>  	struct drm_device_dma *dma = dev->dma;
> -	int i, ret = 0;
> +	int i;
>  	RING_LOCALS;
>  
>  	i810_kernel_lost_context(dev);
> @@ -882,7 +882,7 @@ static int i810_flush_queue(struct drm_device *dev)
>  			DRM_DEBUG("still on client\n");
>  	}
>  
> -	return ret;
> +	return;
>  }
>  
>  /* Must be called with the lock held */
> -- 
> 2.25.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch