Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Sep 2020 11:30:59 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Nathan Chancellor <natechancellor@gmail.com>
Cc:     Eric Anholt <eric@anholt.net>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] drm/vc4: Update type of reg parameter in
 vc4_hdmi_{read,write}
Message-ID: <20200911093059.seyflq66mbvyhsb4@gilmour.lan>
References: <20200910170401.3857250-1-natechancellor@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="nivno6pymk5epqhf"
Content-Disposition: inline
In-Reply-To: <20200910170401.3857250-1-natechancellor@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--nivno6pymk5epqhf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 10, 2020 at 10:04:02AM -0700, Nathan Chancellor wrote:
> Clang warns 100+ times in the vc4 driver along the lines of:
>=20
> drivers/gpu/drm/vc4/vc4_hdmi_phy.c:518:13: warning: implicit conversion
> from enumeration type 'enum vc4_hdmi_field' to different enumeration
> type 'enum vc4_hdmi_regs' [-Wenum-conversion]
>         HDMI_WRITE(HDMI_TX_PHY_POWERDOWN_CTL,
>         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
>=20
> The HDMI_READ and HDMI_WRITE macros pass in enumerators of type
> vc4_hdmi_field but vc4_hdmi_write and vc4_hdmi_read expect a enumerator
> of type vc4_hdmi_regs, causing a warning for every instance of this.
> Update the parameter type so there is no more mismatch.
>=20
> Fixes: 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstract=
ion")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1149
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Applied, thanks!
Maxime

--nivno6pymk5epqhf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX1tD0wAKCRDj7w1vZxhR
xSMEAQCO33V9mqU3u9rBqhRNWajN4iqpvngIcDpnvW4MIldO7gEAqQSnWKYHs8I9
BUH19iF7iojqi5m2AoKIPCbJIyzAvgg=
=YcrL
-----END PGP SIGNATURE-----

--nivno6pymk5epqhf--