Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 11 Sep 2020 10:14:39 +0000
From:   skakit@codeaurora.org
To:     Doug Anderson <dianders@chromium.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Gross <agross@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Akash Asthana <akashast@codeaurora.org>,
        Roja Rani Yarubandi <rojay@codeaurora.org>,
        msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V5 1/4] arm64: dts: qcom: sc7180: Improve the pin config
 settings for CTS and TX
In-Reply-To: <CAD=FV=XYqiGk3QEPxVKCgnYA0FVrizyarSW52HPRGVyAUSugrQ@mail.gmail.com>
References: <1599742438-16811-1-git-send-email-skakit@codeaurora.org>
 <1599742438-16811-2-git-send-email-skakit@codeaurora.org>
 <CAD=FV=XYqiGk3QEPxVKCgnYA0FVrizyarSW52HPRGVyAUSugrQ@mail.gmail.com>
Message-ID: <010101747ca8ea89-168fbb95-b789-4294-81dc-82561c314bf4-000000@us-west-2.amazonses.com>
User-Agent: Roundcube Webmail/1.3.9
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Doug,

On 2020-09-10 20:10, Doug Anderson wrote:
> Hi,
> 
> On Thu, Sep 10, 2020 at 5:55 AM satya priya <skakit@codeaurora.org> 
> wrote:
>> 
>> Remove output-high from CTS and TX as this is not really required. 
>> During
>> bringup to fix transfer failures this was added to match with console 
>> uart
>> settings. Probably some boot loader config was missing then. As it is
>> working fine now, remove it.
>> 
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> Changes in V4:
>>  - This is newly added in V4 to separate the improvements in pin 
>> settings
>>    and wakeup related changes.
>> 
>> Changes in V5:
>>  - As per Doug's comment configured pull-down for CTS pin as earlier.
>> 
>>  arch/arm64/boot/dts/qcom/sc7180-idp.dts | 10 ++++------
>>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> Looks fine to me.  Slight nit that this only applies to the IDP board
> but ${SUBJECT} makes it sound as if this applies to all sc7180.  I
> wouldn't spin just for that, though.  If Bjorn agrees, he can always
> adjust the subject when applying.
> 
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks for reviewing the patches, i will correct this nit in my next 
version.

Thanks,
Satya Priya