Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     mtk.manpages@gmail.com, linux-man@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/24] endian.3: Use 'PRIx32' rather than "%x" when
 printing 'uint32_t' values
To:     Alejandro Colomar <colomar.6.4.3@gmail.com>
References: <20200910211344.3562-1-colomar.6.4.3@gmail.com>
 <20200910211344.3562-3-colomar.6.4.3@gmail.com>
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Message-ID: <99b8d630-131e-b8f7-eb81-d8bb1727da59@gmail.com>
Date:   Fri, 11 Sep 2020 12:13:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200910211344.3562-3-colomar.6.4.3@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/10/20 11:13 PM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>

Just noting here for completeness: see the discussion in patch 01.

Thanks,

Michael

> ---
>  man3/endian.3 | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/man3/endian.3 b/man3/endian.3
> index bdf1efd7e..3a898bb02 100644
> --- a/man3/endian.3
> +++ b/man3/endian.3
> @@ -147,6 +147,7 @@ htobe32(x.u32) = 0x11223344
>  \&
>  .EX
>  #include <endian.h>
> +#include <inttypes.h>
>  #include <stdint.h>
>  #include <stdio.h>
>  #include <stdlib.h>
> @@ -164,9 +165,9 @@ main(int argc, char *argv[])
>      x.arr[2] = 0x33;
>      x.arr[3] = 0x44;	/* Highest-address byte */
>  
> -    printf("x.u32 = 0x%x\en", x.u32);
> -    printf("htole32(x.u32) = 0x%x\en", htole32(x.u32));
> -    printf("htobe32(x.u32) = 0x%x\en", htobe32(x.u32));
> +    printf("x.u32 = 0x%"PRIx32"\en", x.u32);
> +    printf("htole32(x.u32) = 0x%"PRIx32"\en", htole32(x.u32));
> +    printf("htobe32(x.u32) = 0x%"PRIx32"\en", htobe32(x.u32));
>  
>      exit(EXIT_SUCCESS);
>  }
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/