Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp168370pxk; Fri, 11 Sep 2020 03:34:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4KP2hsMLQfskdddBVEjocg4etVZc44F+CGYacC9WagakrMRSaIiSsBj1V7ComIWozkg2+ X-Received: by 2002:a17:906:178d:: with SMTP id t13mr1480253eje.410.1599820490863; Fri, 11 Sep 2020 03:34:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599820490; cv=none; d=google.com; s=arc-20160816; b=zCOQkXL6TJfySz07H3hOpzCmmoreaqiX9NwVxZlbnylWvXNlQG0NnBwmxWdSXChu5u OOQIAysrBh27taY/uBsU1W7XSoxDT3HW6l4FEM/0vxxTLF1DwGrBFZyJOT+0f8WNIOfm LHE7kSMyWgWCtaBXF3PupSMNpk9XhqWHweG12fIPmIGLRTTHqTlSj3cVDwrS5Lc5sPJi iTWu4DjsnTi9Cp31YrL53iftr/9qgDe0Szpo0M9K35mIAu66WnVNJU9kV2B1/sn3eL6+ QuRl+FQzPZ0CT7eobarCR2ISUuJSJT6XYo4hnJr8Ayy6Vr1hfHHAmrIHeyrQsekriEfk Y/gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=9hfrglaZrenA1tu+g5hAu2N6tEduGD5tv+1sxP+epto=; b=BNXJgmBJqAeoH0h8RcGmFNzeqYvMg/7Fyhywabgd83IYiBtxfA8+Sm+EtMdZbbADsO cU1syUlcR16sZxKXwnZRXYK568WFEDGd3KoELs1x8gOTJz4ldvWbWI/3o7PCD1C2hLAd 9qSQnAL0YOZvNkpGvuPvilfPlJUYkVE6tZrNiNn7ZPHtDya+GCwd2HJ95yGTDmM4IDA8 FqsOWgid70M+Y7N4aITj6jRj1NwJkdlCUTfNGPxb4P6OocjPhbtFpUPwU0aUZo4Xoh/S +l0bYqx8Swba2BYhLKF6I4+5E0Ny22qHvhE4TW7xwpAHvhSZL3o9lJPPJfRZm4tlbOYO Chxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c33si1032219edf.530.2020.09.11.03.34.27; Fri, 11 Sep 2020 03:34:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725868AbgIKKc5 (ORCPT + 99 others); Fri, 11 Sep 2020 06:32:57 -0400 Received: from muru.com ([72.249.23.125]:44576 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgIKKcy (ORCPT ); Fri, 11 Sep 2020 06:32:54 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 901FD80A3; Fri, 11 Sep 2020 10:32:53 +0000 (UTC) Date: Fri, 11 Sep 2020 13:33:37 +0300 From: Tony Lindgren To: Andreas Kemnade Cc: khilman@kernel.org, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org Subject: Re: [PATCH] omap3: enable off mode automatically Message-ID: <20200911103337.GH7101@atomide.com> References: <20200911064924.26281-1-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911064924.26281-1-andreas@kemnade.info> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andreas Kemnade [200911 09:50]: > --- a/arch/arm/mach-omap2/pm.h > +++ b/arch/arm/mach-omap2/pm.h > @@ -49,11 +49,7 @@ static inline int omap4_opp_init(void) > extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm); > extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state); > > -#ifdef CONFIG_PM_DEBUG > extern u32 enable_off_mode; > -#else > -#define enable_off_mode 0 > -#endif Hmm isn't the above still needed for the other SoCs? Or is omap3 the only user? Otherwise looks good to me :) Tony